Skip to content

Fix branch name sanitation in preview #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025

Conversation

egeakman
Copy link
Member

@egeakman egeakman commented May 27, 2025

Fixes #1273

@europython-society
Copy link
Member

europython-society commented May 27, 2025

Preview available

Key Value
url https://ci-test-preview-url-fix-branch-name-sanitize.ep-preview.click
last update 2025-05-28T10:18:50.761Z

@egeakman egeakman requested a review from hypha May 27, 2025 23:21
@egeakman
Copy link
Member Author

The sanitation works now, but Nginx is having some trouble, I think:

image

image

@egeakman
Copy link
Member Author

cc @artcz

@egeakman egeakman self-assigned this May 27, 2025
@egeakman
Copy link
Member Author

Thanks Marcin!

@nikoshell
Copy link
Contributor

@egeakman Thank you for investigation. I made small update and now it works.

@nikoshell nikoshell merged commit aac9d2b into ep2025 May 28, 2025
6 checks passed
@nikoshell nikoshell deleted the ci/test/Preview@URL#Fix/branch.name+sanitize branch May 28, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview branch name sanitation does not work
3 participants