Skip to content

Update keynoters. #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2025
Merged

Update keynoters. #1278

merged 4 commits into from
Jun 1, 2025

Conversation

nikoshell
Copy link
Contributor

@nikoshell nikoshell commented May 28, 2025

image

@europython-society
Copy link
Member

europython-society commented May 28, 2025

Preview available

Key Value
url https://ep2025-update-keynoters.ep-preview.click
last update 2025-05-30T08:00:52.833Z

@nikoshell nikoshell requested a review from clytaemnestra May 28, 2025 16:39
@egeakman
Copy link
Member

Is there a specific reason why we redirect to YouTube instead of embedding the player like we did before?

@nikoshell
Copy link
Contributor Author

Is there a specific reason why we redirect to YouTube instead of embedding the player like we did before?

So, other way around, we just embedding the player instead of redirect to YouTube.

@nikoshell nikoshell self-assigned this May 29, 2025
@clytaemnestra
Copy link
Contributor

Is there a specific reason why we redirect to YouTube instead of embedding the player like we did before?

So, other way around, we just embedding the player instead of redirect to YouTube.

@nikoshell if I click on the 'play' button, it redirects me to YT and I can't play it embedded. currently using Chrome version 136.0.7103.116.

I think it would be better if there would be no redirect to YT, unless there are technical reasons not to play it embedded directly on the website.

image

@nikoshell
Copy link
Contributor Author

Is there a specific reason why we redirect to YouTube instead of embedding the player like we did before?

Sorry, it looks that you ware right I didn't understand your comment.

@nikoshell
Copy link
Contributor Author

Is there a specific reason why we redirect to YouTube instead of embedding the player like we did before?

So, other way around, we just embedding the player instead of redirect to YouTube.

@nikoshell if I click on the 'play' button, it redirects me to YT and I can't play it embedded. currently using Chrome version 136.0.7103.116.

I think it would be better if there would be no redirect to YT, unless there are technical reasons not to play it embedded directly on the website.
image

There was a bug.
Generally whole idea was to have YouTube player for all markdown content not only for md pages.
fyi, right now we use two different renderers

@nikoshell nikoshell force-pushed the ep2025-update-keynoters branch from db2d987 to 630f528 Compare May 30, 2025 07:58
@nikoshell
Copy link
Contributor Author

YouTube feature for markdown sections have some issue across dev and prod I will prepare it as separate PR.

Copy link
Member

@egeakman egeakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's do the YouTube embedding in another PR!

@nikoshell nikoshell merged commit 964f028 into ep2025 Jun 1, 2025
6 checks passed
@nikoshell nikoshell deleted the ep2025-update-keynoters branch June 1, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants