-
Notifications
You must be signed in to change notification settings - Fork 64
Update keynoters. #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update keynoters. #1278
Conversation
Preview available
|
Is there a specific reason why we redirect to YouTube instead of embedding the player like we did before? |
So, other way around, we just embedding the player instead of redirect to YouTube. |
@nikoshell if I click on the 'play' button, it redirects me to YT and I can't play it embedded. currently using Chrome version 136.0.7103.116. I think it would be better if there would be no redirect to YT, unless there are technical reasons not to play it embedded directly on the website. ![]() |
Sorry, it looks that you ware right I didn't understand your comment. |
There was a bug. |
db2d987
to
630f528
Compare
YouTube feature for markdown sections have some issue across dev and prod I will prepare it as separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, let's do the YouTube embedding in another PR!
Uh oh!
There was an error while loading. Please reload this page.