Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ChatBox dark mode color setting #185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ChatBox dark mode color setting #185

wants to merge 1 commit into from

Conversation

chanheeis
Copy link
Contributor

@chanheeis chanheeis commented Nov 14, 2021 •
edited
Loading

Description

before_dark

  • dark mode일 때 ChatBox의 배경 색상과 텍스트 색상의 대비도가 낮음
  • 가독성에 영향을 미칠 수 있는 부분이므로, dark mode일 때의 색상을 따로 정의하였음
  • 배경 색상값과 그림자 색상값을 마크다운의 <pre> 스타일과 일치시킴
  • 추가적으로, padding값과 borderRadius 값을 여유있게 수정하였음

light mode의 <pre> 스타일 예시
color_light

dark mode의 <pre> 스타일 예시
color_dark

Related Issues

resolve #184

Checklist ✋

  • 모든 변경점들을 확인했으며 적절히 설명했습니다.
  • 빌드가 정상적으로 수행됨을 확인했습니다. (yarn build)

josworks27
josworks27 approved these changes Nov 14, 2021
View reviewed changes
Copy link
Member

@josworks27 josworks27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 수고많으셨습니다 ~!👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josworks27 josworks27 josworks27 approved these changes

@milooy milooy Awaiting requested review from milooy

@NamNamju NamNamju Awaiting requested review from NamNamju

@jiyoon1156 jiyoon1156 Awaiting requested review from jiyoon1156

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: ChatBox dark mode color setting
2 participants
@chanheeis @josworks27