Skip to content

Commit ffd3647

Browse files
committed
Address review feedback
Clarify wording around default list of command-queues used for command-buffer enqueue.
1 parent 62b11fb commit ffd3647

4 files changed

+13
-10
lines changed

api/cl_khr_command_buffer.asciidoc

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,17 +99,17 @@ following reasons:
9999

100100
The command-buffer object has no in-order/out-of-order property set on creation,
101101
it is out-of-order, and command ordering is defined by the dependencies set when
102-
commands are created. Command dependencies can be define in 3 ways:
102+
commands are created. Command dependencies can be defined in 3 ways:
103103

104104
1. Device-side {cl_sync_point_khr_TYPE} synchronization-points, providing an
105105
explicit list of the commands to depend on.
106106
2. Appending a {clCommandBarrierWithWaitListKHR} barrier command.
107107
3. Passing an in-order queue when creating the command, creating an implicit
108-
dependency on the any previous command created in the command-buffer using
108+
dependency on the previous command created in the command-buffer using
109109
the same queue.
110110

111111
{clEnqueueCommandBufferKHR} submissions to an out-of-order queue have the same
112-
execution semantics are other operations enqueued to an out-of-order queue,
112+
execution semantics as other operations enqueued to an out-of-order queue,
113113
such as {clEnqueueFillBuffer}, where execution between enqueued operations may
114114
happen concurrently unless dependencies between the operations are expressed
115115
with events.
@@ -465,6 +465,8 @@ features:
465465
* 0.9.5, 2024-07-24
466466
** Add a properties parameter to all command recording entry-points
467467
(provisional).
468-
* 0.9.6, 2024-12-13
468+
* 0.9.6, 2024-10-02
469+
** Add device query for supported queue properties (provisional).
470+
* 0.9.7, 2024-12-13
469471
** Refactor queue compatability between command-buffer creation and enqueue
470472
(provisional).

api/cl_khr_command_buffer_multi_device.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,4 +314,4 @@ require it.
314314
functions (provisional).
315315
* Revision 0.9.2, 2024-12-13
316316
** Update clRemapCommandBufferKHR behavior to match cl_khr_command_buffer
317-
version 0.9.6 (provisional).
317+
version 0.9.7 (provisional).

api/opencl_runtime_layer.asciidoc

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14118,11 +14118,12 @@ the queue is an out-of-order queue, then no extra dependencies on previous
1411814118
commands using the same queue are created. All queue properties other than
1411914119
{CL_QUEUE_OUT_OF_ORDER_EXEC_MODE_ENABLE} are ignored for the purposes of command
1412014120
creation, with the exception of any vendor extension defined queue properties
14121-
that explcitly define semantics for this purpose.
14121+
that explicitly define semantics for this purpose.
1412214122

14123-
The command-queues used on command-buffer creation must be replaced on
14124-
command-buffer enqueue with the command-queues to execute the command-buffer
14125-
on. These may be different command-queues, provided for each element the
14123+
When enqueuing a command-buffer, a list of command-queues to execute the
14124+
command-buffer on can be passed by the user, otherwise the command-queues set
14125+
on command-buffer creation are used by default for execution. A user passed
14126+
list may contain different command-queues, provided for each element the
1412614127
substitute command-queue matches the device and context of the command-queue
1412714128
used on command-buffer creation. Each command-queue in the enqueue list must
1412814129
also have the minimum properties defined by

xml/cl.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7410,7 +7410,7 @@ server's OpenCL/api-docs repository.
74107410
<enum name="CL_MEM_DEVICE_ID_INTEL"/>
74117411
</require>
74127412
</extension>
7413-
<extension name="cl_khr_command_buffer_multi_device" revision="0.9.2" supported="opencl" depends="cl_khr_command_buffer" ratified="opencl" provisional="true" comment="requires cl_khr_command_buffer 0.9.6 or later">
7413+
<extension name="cl_khr_command_buffer_multi_device" revision="0.9.2" supported="opencl" depends="cl_khr_command_buffer" ratified="opencl" provisional="true" comment="requires cl_khr_command_buffer 0.9.7 or later">
74147414
<require>
74157415
<type name="CL/cl.h"/>
74167416
</require>

0 commit comments

Comments
 (0)