Feat/sign up form test #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
๋์ ๋ฆฌ๋ทฐ ์์ /์ญ์ ๋๊ด์ ์ ๋ฐ์ดํธ ์ ์ฉ
dowookims
approved these changes
Oct 31, 2024
| __esModule: true, | ||
| default: ({ onComplete }: { onComplete: (data: PostAddress) => void }) => ( | ||
| <div data-testid="daum-postcode"> | ||
| <button onClick={() => onComplete({ zonecode: '12345', address: 'Seoul, Korea' })}> |
There was a problem hiding this comment.
zoneCode์ Seoul, Korea๋ ์์ ๋ณ์๋ก ๊ด๋ฆฌํด์ฃผ๋ฉด ์ข์๊ฒ ๊ฐ์์
Comment on lines
+45
to
+58
| it('renders all input fields with appropriate data-testid attributes', () => { | ||
| render(<SignUpForm onSubmit={mockOnSubmit} onValidChange={mockOnValidChange} />); | ||
| const fields = [ | ||
| 'name', | ||
| 'email', | ||
| 'password', | ||
| 'confirmPassword', | ||
| 'phone', | ||
| 'postalCode', | ||
| 'streetAddress', | ||
| 'detailAddress', | ||
| ]; | ||
| fields.forEach((testId) => expect(screen.getByTestId(testId)).toBeInTheDocument()); | ||
| }); |
There was a problem hiding this comment.
์๋ช ํ ๊ฒ์ ๊ผญ ๋ค ๋ฃ์ง ์์๋ ๋ ๊ฒ ๊ฐ์ต๋๋ค..!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat/sign-up-form-test
๐Part
๐ ์์ ๋ด์ฉ
๋ชจ๋ ์ ๋ ฅ ํ๋๊ฐ data-testid ์์ฑ์ผ๋ก ๋ ๋๋ง๋๋์ง ํ์ธ
์๋ชป๋ ์ ๋ ฅ๊ฐ์ ์ ๋ ฅํ์ ๋ onValidChange๊ฐ false๋ก ํธ์ถ๋๋์ง ๊ฒ์ฆ
์ฃผ์ ๊ฒ์ ๋ชจ๋ฌ์ ์ด๊ณ ์ฃผ์๋ฅผ ์ ํํ์ ๋ postalCode์ streetAddress ํ๋๊ฐ ์ฌ๋ฐ๋ฅด๊ฒ ์ ๋ฐ์ดํธ๋๋์ง ํ์ธ
์ด๋ฏธ์ง ์ฒจ๋ถ
๐ง ์์ผ๋ก์ ๊ณผ์