Type checking #357
Merged
Type checking #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added type hints to the general cog.
…l instances of ctx (in constructors) with ctx: DozerContext. theres no way this can come back to bite me /s
… it makes them worse). Sorry. Also, about the missing module docstring I see no missing module docstring. Also mypy hates me.
|
working on #356 |
…t i hope. whatever that is. doesnt show up on my local pylint
|
none of these problems are coming up in my local pylint. im trying to fix them. |
JayFromProgramming
requested review from
JayFromProgramming,
tweirtx and
devyntk
and removed request for
tweirtx
tweirtx
previously approved these changes
Mar 28, 2022
tweirtx
previously approved these changes
May 10, 2022
JayFromProgramming
dismissed stale reviews from tweirtx and themself
via
10a3409
JayFromProgramming
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is like sorta first steps of adding type hints to all the code. mypy hates it but it runs fine. Sorry for the merge conflicts and ton of files edited. A lot of those are formatting and stuff only.