Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current limiting everywhere!!!! #264

Open
TaylerUva opened this issue Feb 8, 2025 · 4 comments · May be fixed by #268
Open

Current limiting everywhere!!!! #264

TaylerUva opened this issue Feb 8, 2025 · 4 comments · May be fixed by #268
Assignees
Labels
⏳ In Progress Issue that is currently being worked on ‼️ Minimum viable bot URGENT - REQUIRED for minimal viable robot. Issue should be addressed immediately
Milestone

Comments

@TaylerUva
Copy link
Member

Especially algae intake
Also elevator

@TaylerUva TaylerUva added the ‼️ Minimum viable bot URGENT - REQUIRED for minimal viable robot. Issue should be addressed immediately label Feb 8, 2025
@TaylerUva TaylerUva modified the milestones: Week 5, Week 6 Feb 8, 2025
@Alenguye582 Alenguye582 self-assigned this Feb 10, 2025
@Alenguye582
Copy link
Contributor

Alenguye582 commented Feb 10, 2025

@ACat701 @TaylerUva Should we use supply or stator current limiting this year (or both)? I know that "supply current is the current drawn from the battery," but CTRE recommends using stator current first and then using supply later. Stator can also reduce battery consumption. We've seen some results with messing around with stator on Two Face, right?

Image

Image

@ACat701
Copy link
Contributor

ACat701 commented Feb 10, 2025

@Alenguye582
The use-cases of supply and stator limits are kinda different. In my head (which could be totally wrong), stator limits are for slowing down mechanisms that are temporarily drawing too much current while supply limits are for stopping mechanisms when they're breaking themselves. I could be totally wrong though; @TaylerUva back me up
We used a supply current limit on our 2023 elevator to stop movement when it tried to do a pull up on the charge station or the poles. We've used stator current limits everywhere else. I think we should stick to stator current limits on everything, and add supply current limits to mechanisms that can do "pull ups"- thoughts?

Image

@Alenguye582 Alenguye582 linked a pull request Feb 10, 2025 that will close this issue
@Alenguye582
Copy link
Contributor

Alenguye582 commented Feb 10, 2025

stator limits are for slowing down mechanisms that are temporarily drawing too much current while supply limits are for stopping mechanisms when they're breaking themselves. I think we should stick to stator current limits on everything, and add supply current limits to mechanisms that can do "pull ups"- thoughts?

Okay, that makes sense. Because I swear we were using all supply for 2024 and I wanted to question if we should use stator for anything. So to make sure I got this right: Supply for elevator, climber, and algae pivot? And stator for everything else?

@ACat701
Copy link
Contributor

ACat701 commented Feb 10, 2025

  • You want stator on everything, no matter what. You can have supply and stator on a motor.
  • No climber current limiting for now, since it kinda needs to hold up the entire weight of the robot 😬
  • The list of subsystems to add supply to (apart from the climber) looks good!

@ACat701 ACat701 added the ⏳ In Progress Issue that is currently being worked on label Feb 10, 2025
@TaylerUva TaylerUva modified the milestones: Week 6, Week 7 Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏳ In Progress Issue that is currently being worked on ‼️ Minimum viable bot URGENT - REQUIRED for minimal viable robot. Issue should be addressed immediately
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants