Skip to content

Commit 28d2af4

Browse files
Collect TODO comments
1 parent b1c856b commit 28d2af4

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ pytest = "^5.2"
1717
[tool.poetry.extras]
1818
client_id = ["androguard"]
1919
filelike = ["http-seekable-file"]
20-
# TODO: Make `filelike` extra depend on `music-service-async-interface['filelike']`, not directly on `http-seekable-file['async']`
20+
# TODO [$5f4dbbded370b70007650160]: Make `filelike` extra depend on `music-service-async-interface['filelike']`, not directly on `http-seekable-file['async']`
2121

2222
[build-system]
2323
requires = ["poetry>=0.12"]

tests/test_tidal_async.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
def test_version():
55
assert __version__ == '0.1.0'
66

7-
# TODO: Unit tests!
7+
# TODO [$5f4dbbded370b70007650161]: Unit tests!

tidal_async/api.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ async def reload_info(self):
5050

5151
@classmethod
5252
async def from_id(cls, sess: 'TidalSession', id_):
53-
# TODO: Make sure from_id cannot be called on TidalObject
53+
# TODO [$5f4dbbded370b70007650162]: Make sure from_id cannot be called on TidalObject
5454
# Same goes for from_url
5555
# I was pretty sure I can just mark it @abstractmethod and don't override it, but it looks like I was wrong
5656
obj = cls(sess, {'id': id_})
@@ -108,7 +108,7 @@ def album(self):
108108
def cover(self):
109109
return self.album.cover
110110

111-
# TODO: Track.artist
111+
# TODO [$5f4dbbded370b70007650163]: Track.artist
112112

113113
@property
114114
def audio_quality(self):
@@ -133,7 +133,7 @@ async def get_file_url(self, audio_quality=AudioQuality.Master) -> str:
133133
return (await self._stream_manifest(audio_quality))['urls'][0]
134134

135135
async def get_metadata(self):
136-
# TODO: fix Track.get_metadata
136+
# TODO [$5f4dbbded370b70007650164]: fix Track.get_metadata
137137
album = self.album
138138
await album.reload_info()
139139

@@ -170,7 +170,7 @@ async def get_metadata(self):
170170

171171

172172
class Playlist(TidalObject, generic.TrackCollection):
173-
# TODO: Reimplement Playlist.from_id and Playlist.__init__
173+
# TODO [$5f4dbbded370b70007650165]: Reimplement Playlist.from_id and Playlist.__init__
174174
# Playlist field for `id` is named `uuid`, not `id` as in other objects
175175
# Should also fix @wvffle 's workaround with self.dict.update
176176
urlname = 'playlist'
@@ -227,7 +227,7 @@ async def tracks(self) -> AsyncGenerator[Track, None]:
227227
class Album(TidalObject, generic.TrackCollection):
228228
urlname = 'album'
229229

230-
# TODO: Album.artist
230+
# TODO [$5f4dbbded370b70007650166]: Album.artist
231231

232232
def __repr__(self):
233233
cls = self.__class__
@@ -246,7 +246,7 @@ def cover(self):
246246

247247
async def tracks(self) -> AsyncGenerator[Track, None]:
248248
# TODO [#13]: Convert Album.tracks to generator
249-
# TODO: Find out if it is possible for tracks request on album to show not-all results
249+
# TODO [$5f4dbbded370b70007650167]: Find out if it is possible for tracks request on album to show not-all results
250250
# If it can - run multiple requests
251251
if 'items' not in self:
252252
resp = await self.sess.get(f"/v1/albums/{self.id}/tracks", params={

tidal_async/utils.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ async def cli_auth_url_getter(authorization_url):
3535

3636
def parse_title(result, artists=None):
3737
# https://github.com/divadsn/tidal-telegram-bot/blob/master/tidalbot/utils.py#L60
38-
# TODO: Read parse_title carefully and rewrite
38+
# TODO [$5f4dbbded370b70007650168]: Read parse_title carefully and rewrite
3939
if artists and len(artists) > 1:
4040
title = result.title.strip() # just in case
4141

0 commit comments

Comments
 (0)