Display Link: Value Display Options

[Damdrara]

Describe the Bug

When selecting "List matching Items", the Value display option on the Fabric version gives the following options:

...which doesn't make a whole lot of sense for items.

Reproduction Steps

1. Put a content observer / smart observer on a vault
2. put a display link on the observer
3. check the options

Expected Result

The forge version gives these:

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 11

Mod Version

0.5.1b

Minecraft Version

1.19.2

Other Mods

No response

Additional Context

also happens on 0.5.0i

[electricsteve]

first, make sure it is pointing at a container with items in it, second, the forge screenshot is taken in older version, so maybe it isn't rellevent in the newest version.

[Damdrara]

It definitely has items in it, that's not the issue.

I tested the bug on various versions, with the exact same world. it occures on Fabric on both 0.5.0i with the Content Observer and 0.5.1b with the Smart Observer, and it did not occur on Forge on either version.

[Damdrara]

Without digging too deep, super quick code search finds the related change:

c9114f1

It seems this was specifically changed for the Fabric version due to different fluid mechanics, but it wasn't taken into account that the same label is used for items as well, not just fluids.

[MrGreenTea]

Yeah I've come across this as well. It seems to be an issue with the translation as it does not differentiate between the Item List and Fluid list:

Here is the key in the Translation file Source

Here it is used for the ValueList: ValueListDisplaySource.java

It is the same as used in FluidList: FluidListDisplaySource.java

[nicolas-rabault]

I experience the same problem on V0.5.1f