Add Regex test cases for pt_PT PhoneNumber #925

- Add tests for e164PhoneNumber, e164MobileNumber and
  e164LandlineNumber.

- Simplify regex for phoneNumber.

Note:
- Regex for phoneNumber was duplicating some information. It also
  validated for landline numbers starting at 20 even tho it wasn't
  present in the provider $formats.

- Regex for country code, mobile number and landline number could be
  placed in a const variable. The problem is: there's some issues with
  interpolating self/static variables and concatenation would probably
  be hard to read.

Author: Head0nF1re

src/Provider/pt_PT/PhoneNumber.php

@@ -5,12 +5,12 @@
 class PhoneNumber extends \Faker\Provider\PhoneNumber
 {
     /**
-     * Returns the pt_PT phone country code.
+     * Phone country code.
      */
     public const COUNTRY_CODE = '+351';
 
     /**
-     * pt_PT Mobile Service Codes
+     * Mobile Service Codes
      */
     public const MOBILE_SERVICE_CODE = [
         91,
@@ -20,7 +20,7 @@ class PhoneNumber extends \Faker\Provider\PhoneNumber
     ];
 
     /**
-     * pt_PT Geographic Area Codes
+     * Geographic Area Codes
      */
     public const AREA_CODE = [
         21,
@@ -35,24 +35,24 @@ class PhoneNumber extends \Faker\Provider\PhoneNumber
     ];
 
     /**
-     * pt_PT Geographic Area and Mobile Service Codes
+     * Geographic Area and Mobile Service Codes
      */
-    public const AREA_OR_MOBILE_SERVICE_CODE = [
-        ...self::MOBILE_SERVICE_CODE,
+    public const AREA_AND_MOBILE_SERVICE_CODE = [
         ...self::AREA_CODE,
+        ...self::MOBILE_SERVICE_CODE,
     ];
 
     /**
      * @see http://en.wikipedia.org/wiki/Telephone_numbers_in_Portugal
      */
     protected static $formats = [
-        '{{countryCode}} {{areaOrMobileServiceCode}}#######',
+        '{{countryCode}} {{areaAndMobileServiceCode}}#######',
         '{{mobileServiceCode}}#######',
         '{{areaCode}}#######',
     ];
 
     protected static $e164Formats = [
-        '{{countryCode}}{{areaOrMobileServiceCode}}#######',
+        '{{countryCode}}{{areaAndMobileServiceCode}}#######',
     ];
 
     protected static $e164MobileFormat = [
@@ -75,23 +75,23 @@ public static function mobileNumber()
         return static::numerify(static::randomElement(static::$mobileNumberPrefixes));
     }
 
-    public static function areaOrMobileServiceCode()
+    public static function areaAndMobileServiceCode()
     {
-        return self::randomElement(static::AREA_OR_MOBILE_SERVICE_CODE);
+        return static::randomElement(self::AREA_AND_MOBILE_SERVICE_CODE);
     }
 
     public static function areaCode()
     {
-        return self::randomElement(static::AREA_CODE);
+        return static::randomElement(self::AREA_CODE);
     }
 
     public static function mobileServiceCode()
     {
-        return self::randomElement(static::MOBILE_SERVICE_CODE);
+        return static::randomElement(self::MOBILE_SERVICE_CODE);
     }
 
     /**
-     * Returns the pt_PT phone country code.
+     * Returns the phone country code.
      *
      * @return string
      */
@@ -101,8 +101,8 @@ public static function countryCode()
     }
 
     /**
-     * Returns a pt_PT mobile number in E.164 format.
-     * 
+     * Returns a mobile number in E.164 format.
+     *
      * Example: +35193XXXXXXX
      *
      * @return string
@@ -113,8 +113,8 @@ public function e164MobileNumber()
     }
 
     /**
-     * Returns a pt_PT landline number in E.164 format.
-     * 
+     * Returns a landline number in E.164 format.
+     *
      * Example: +35121XXXXXXX
      *
      * @return string
@@ -123,4 +123,4 @@ public function e164LandlineNumber()
     {
         return static::numerify($this->generator->parse(static::randomElement(static::$e164LandlineFormat)));
     }
-}
+}

test/Provider/pt_PT/PhoneNumberTest.php

@@ -14,14 +14,29 @@ final class PhoneNumberTest extends TestCase
 {
     public function testPhoneNumberReturnsPhoneNumberWithOrWithoutPrefix(): void
     {
-        self::assertMatchesRegularExpression('/^(9[1,2,3,6][0-9]{7})|(2[0-9]{8})|(\+351 [2][0-9]{8})|(\+351 9[1,2,3,6][0-9]{7})/', $this->faker->phoneNumber());
+        self::assertMatchesRegularExpression('/^(?:\+351 )?(?:9[1,2,3,6][0-9]{7}|2[1-9][0-9]{7})$/', $this->faker->phoneNumber());
     }
 
-    public function testMobileNumberReturnsMobileNumberWithOrWithoutPrefix(): void
+    public function testMobileNumberReturnsMobileNumberWithoutPrefix(): void
     {
         self::assertMatchesRegularExpression('/^(9[1,2,3,6][0-9]{7})/', $this->faker->mobileNumber());
     }
 
+    public function testE164PhoneNumberReturnsE164MobileOrLandlineNumber(): void
+    {
+        self::assertMatchesRegularExpression('/^\+351(?:9[1,2,3,6][0-9]{7}|2[1-9][0-9]{7})$/', $this->faker->e164PhoneNumber());
+    }
+
+    public function testE164MobileNumberReturnsE164MobileNumber(): void
+    {
+        self::assertMatchesRegularExpression('/^\+3519[1,2,3,6][0-9]{7}$/', $this->faker->e164MobileNumber());
+    }
+
+    public function testE164LandlineNumberReturnsE164LandlineNumber(): void
+    {
+        self::assertMatchesRegularExpression('/^\+3512[1-9][0-9]{7}$/', $this->faker->e164LandlineNumber());
+    }
+
     protected function getProviders(): iterable
     {
         yield new PhoneNumber($this->faker);