Fix standard en_GB VAT numbers being generated with an incorrect digit length #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamja
force-pushed
the
gb-vat-fix-missing-zero-padding
branch
from
f658a52 to
bd7d961
Compare
…er of digits Standard UK VAT numbers should be 9 digits. If the Modulus 97 block of a UK VAT number has a leading 0, this zero gets thrown out when sprintf casts this block from a string (%s) to an int (%d) during formatting. For example, a check block of "07" would end up like: GB216 5727 7 but it should be: GB216 5727 07
liamja
force-pushed
the
gb-vat-fix-missing-zero-padding
branch
from
bd7d961 to
d2f6714
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Standard UK VAT numbers should be 9 digits.
If the Modulus 97 block of a UK VAT number has a leading 0, this zero gets thrown out when sprintf casts this block from a string (%s) to an int (%d) during formatting.
For example, a check block of "07" would end up like:
GB216 5727 7but it should be:
GB216 5727 07Author's checklist
Summary of changes
Change
sprintffrom using%dto%sso that zero-padded strings are not truncated when casting to integers, to preserve leading zeroes and retain a digit length of 9 for standard VAT numbers.Review checklist
CHANGELOG.md