Extend Gradle integration test to check checksums and metadata marker #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
jjohannes
force-pushed
the
validate-checksums-in-gmm
branch
from
55bcf5c to
ffcf2c5
Compare
jjohannes
changed the title
|
I guess we'll keep this as WIP until modules are fixed, to avoid breaking the build? |
|
I switched this PR to test against Once |
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate that the checksums for the Jar in the
.modulefile corresponds to the actual checksum of the Jar.This is not correct right now for some modules, because the Jar is modified by other plugins (e.g. moditec) after the Gradle metadata plugin computed size and checksums.
Checks what is reported here: FasterXML/jackson-databind#4985