-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flake support #78
Add flake support #78
Conversation
f296bc8
to
27fb292
Compare
Wow! Thanks for your PR!
That's Ok!
That's Ok, but I will try to release a new version with some bug fix. In that case, can I ping you in order you do a new small PR to remove the patch?
Since I am not yet a
Can you open an Issue to track it? Now, I was wondering how can |
Yes! I will be glad to remove the patch
Sadly, you can't do much about this. You can ping me, when you want the flake updated though. Usually, unless something fundamentally changed (like the new system dependencies or changes to how the program is built), the only thing that will need to be changed for One automate solution could be for GitHub (using CI/CD) to try to update the
I could, but I see it as kind of useless. Pretty much 99% of the consumers/users of this flake will be adding it to their own flake via inputs and then straight into their system packages or just running
Well, you can't! I simply create the |
Again, thank you so much!
Ok, then no problem :D
Ok, perfect. So I think that we should add to the README this information, what you think about that? |
Thanks for your contribution! |
Closes #76
Context: #77 (comment)
About these lines:
The reason I'm pinning to a specific commit is that:
cargoHash
, which produces an exact hash of all the dependencies (plus other factors, e.g.,pname
), so any changes to theCargo.lock
will result in a completely different hash and be unable to build the flake.flake.nix
relies on a patch to fixbuild.rs
in order to work properly on Nixsrc = ./.;
would just mean it breaks in the future and breaks the reproducible "promise"I do not plan on adding support for a
devShell
as I don't know how to write Rust code or have any meaningful knowledge in Rust; thus, I can't guarantee a properdevShell
experienceAlthough I would imagine anyone familiar with Nix who wants to develop this project would most likely have the know-how to add
devShell
support themselves better than I could.Currently, it builds and runs on
x86_64-linux
andaarch64-darwin
. I don't own anaarch64-linux
orx86_64-darwin
machine, but theoretically, they shouldn't have any issues either.