test: remove n-mask-logger

n-mask-logger has been fully removed from the FT's tech estate which
means we can safely remove it from the compatibility tests. I've left
the equivalent Reliability Kit logs in so that we don't lose
compatibility in future, however there's no need to run mask logger as
well.

Author: rowanmanning

package-lock.json

@@ -31,7 +31,6 @@
   },
   "devDependencies": {
     "@financial-times/n-logger": "^10.3.0",
-    "@financial-times/n-mask-logger": "^7.2.0",
     "@types/events": "^3.0.3",
     "@types/lodash.clonedeep": "^4.5.9"
   }

packages/logger/package.json

@@ -194,15 +194,7 @@ module.exports = [
 		// Reliability kit does not send the `message` as an empty string
 		// if one is not present – it explicitly sets it to `null`.
 		expectedOutput: {
-			nextMaskLogger: {
-				level: 'info',
-				name: 'L. Ogger',
-				age: 32,
-				email: '*****',
-				password: '*****',
-				role: 'Developer',
-				message: ''
-			},
+			// n-mask-logger test case removed - it's not in use anywhere
 			reliabilityKitMaskLogger: {
 				level: 'info',
 				name: 'L. Ogger',
@@ -234,16 +226,7 @@ module.exports = [
 		// Reliability kit does not send the `message` as an empty string
 		// if one is not present – it explicitly sets it to `null`.
 		expectedOutput: {
-			nextMaskLogger: {
-				level: 'info',
-				foo: 'bar',
-				inner: {
-					some: 'field',
-					deep: { password: '*****' },
-					email: '*****'
-				},
-				message: ''
-			},
+			// n-mask-logger test case removed - it's not in use anywhere
 			reliabilityKitMaskLogger: {
 				level: 'info',
 				foo: 'bar',
@@ -264,10 +247,7 @@ module.exports = [
 			args: ['Oh look password = 123abc']
 		},
 		expectedOutput: {
-			nextMaskLogger: {
-				level: 'info',
-				message: 'Oh look password = *****'
-			},
+			// n-mask-logger test case removed - it's not in use anywhere
 			reliabilityKitMaskLogger: {
 				level: 'info',
 				message: 'Oh look password = *****'
@@ -602,21 +582,7 @@ module.exports = [
 			]
 		},
 		expectedOutput: {
-			nextMaskLogger: {
-				level: 'info',
-				message: 'Test message',
-				list: [
-					{
-						email: '*****',
-						subList: [
-							{
-								postcode: '*****'
-							}
-						]
-					},
-					'password = *****'
-				]
-			},
+			// n-mask-logger test case removed - it's not in use anywhere
 			reliabilityKitMaskLogger: {
 				level: 'info',
 				message: 'Test message',
@@ -652,15 +618,7 @@ module.exports = [
 		// properties only. Reliability Kit also doesn't deal with errors found in
 		// other properties, this is for backwards compatibility with n-logger.
 		expectedOutput: {
-			nextMaskLogger: {
-				level: 'info',
-				message: 'password = *****',
-				name: 'Error',
-				nestedError: {
-					message: 'email = *****',
-					name: 'Error'
-				}
-			},
+			// n-mask-logger test case removed - it's not in use anywhere
 			reliabilityKitMaskLogger: {
 				level: 'info',
 				message: null,
@@ -884,13 +842,7 @@ module.exports = [
 			]
 		},
 		expectedOutput: {
-			nextMaskLogger: {
-				level: 'info',
-				message: 'updateProfile',
-				result: 'success',
-				userId: 'abc123',
-				apiEnv: 'PROD'
-			},
+			// n-mask-logger test case removed - it's not in use anywhere
 			reliabilityKitMaskLogger: {
 				level: 'info',
 				message: 'updateProfile',
@@ -927,23 +879,7 @@ module.exports = [
 			]
 		},
 		expectedOutput: {
-			nextMaskLogger: {
-				level: 'error',
-				message: 'editBillingDetails',
-				error: {
-					url: '/example',
-					status: 500,
-					method: 'post',
-					responseBody: {
-						user: {
-							email: '*****'
-						}
-					},
-					headers: {
-						'X-Request-Id': '123'
-					}
-				}
-			},
+			// n-mask-logger test case removed - it's not in use anywhere
 			reliabilityKitMaskLogger: {
 				level: 'error',
 				message: 'editBillingDetails',

packages/logger/test/end-to-end/compatibility-test-cases.js

@@ -36,19 +36,6 @@ describe('@dotcom-reliability-kit/logger vs @financial-times/n-logger', () => {
 				});
 			}
 
-			if (expectedOutput.nextMaskLogger) {
-				it('outputs the expected n-mask-logger logs', () => {
-					const log = findLogWithPropertyValue(
-						logs,
-						'_logger',
-						'nextMaskLogger'
-					);
-					expect(log).toBeTruthy();
-					const cleanLog = cleanLogForTesting(log);
-					expect(cleanLog).toEqual(expectedOutput.nextMaskLogger);
-				});
-			}
-
 			if (expectedOutput.reliabilityKit) {
 				it('outputs the expected reliability-kit logs', () => {
 					const log = findLogWithPropertyValue(

packages/logger/test/end-to-end/compatibility.spec.js

@@ -8,11 +8,9 @@ process.env.SPLUNK_LOG_LEVEL = 'silly';
 process.env.LOG_DISABLE_PRETTIFIER = 'true';
 
 const nLogger = require('@financial-times/n-logger').default;
-const MaskLogger = require('@financial-times/n-mask-logger');
 const reliabilityKitLogger = require('../../../lib');
 const testCases = require('../compatibility-test-cases');
 
-const nMaskLogger = new MaskLogger();
 const reliabilityKitMaskLogger = new reliabilityKitLogger.Logger({
 	transforms: [reliabilityKitLogger.transforms.legacyMask()]
 });
@@ -36,11 +34,6 @@ if (reliabilityKitLogger[method]) {
 	reliabilityKitLogger[method](...args, { _logger: 'reliabilityKit' });
 }
 
-// Run n-mask-logger
-if (nMaskLogger[method]) {
-	nMaskLogger[method](...args, { _logger: 'nextMaskLogger' });
-}
-
 // Run reliability kit masked logger
 if (reliabilityKitMaskLogger[method]) {
 	reliabilityKitMaskLogger[method](...args, {