chore: reduce the dependency count

The `sdk-node` package actually includes quite a few of the dependencies
we've been using. We can reduce our maintenance overhead a little by
removing these and relying on sub-properties of the SDK.

Author: rowanmanning

package-lock.json

@@ -2,7 +2,9 @@ const {
 	OTLPMetricExporter
 } = require('@opentelemetry/exporter-metrics-otlp-proto');
 const { CompressionAlgorithm } = require('@opentelemetry/otlp-exporter-base');
-const { PeriodicExportingMetricReader } = require('@opentelemetry/sdk-metrics');
+require('@opentelemetry/sdk-node');
+const { PeriodicExportingMetricReader } =
+	require('@opentelemetry/sdk-node').metrics;
 const logger = require('@dotcom-reliability-kit/logger');
 const { METRICS_USER_AGENT } = require('./user-agents');
 

packages/opentelemetry/lib/config/metrics.js

@@ -1,5 +1,5 @@
 const appInfo = require('@dotcom-reliability-kit/app-info').semanticConventions;
-const { Resource } = require('@opentelemetry/resources');
+const { Resource } = require('@opentelemetry/sdk-node').resources;
 const {
 	SEMRESATTRS_CLOUD_PROVIDER,
 	SEMRESATTRS_CLOUD_REGION,
@@ -12,7 +12,7 @@ const {
 /**
  * Create a Resource object using gathered app info.
  *
- * @returns {import('@opentelemetry/sdk-node').NodeSDKConfiguration['resource']}
+ * @returns {import('@opentelemetry/sdk-node').resources.Resource}
  */
 exports.createResourceConfig = function createResourceConfig() {
 	// We set OpenTelemetry resource attributes based on app data

packages/opentelemetry/lib/config/resource.js

@@ -1,10 +1,9 @@
 const {
 	OTLPTraceExporter
 } = require('@opentelemetry/exporter-trace-otlp-proto');
-const {
-	NoopSpanProcessor,
-	TraceIdRatioBasedSampler
-} = require('@opentelemetry/sdk-trace-base');
+const { NoopSpanProcessor, TraceIdRatioBasedSampler } =
+	require('@opentelemetry/sdk-node').tracing;
+
 const logger = require('@dotcom-reliability-kit/logger');
 const { TRACING_USER_AGENT } = require('./user-agents');
 

packages/opentelemetry/lib/config/tracing.js

@@ -2,7 +2,6 @@ const { createInstrumentationConfig } = require('./config/instrumentations');
 const { createMetricsConfig } = require('./config/metrics');
 const { createResourceConfig } = require('./config/resource');
 const { createTracingConfig } = require('./config/tracing');
-const { diag, DiagLogLevel } = require('@opentelemetry/api');
 const opentelemetrySDK = require('@opentelemetry/sdk-node');
 const logger = require('@dotcom-reliability-kit/logger');
 
@@ -52,13 +51,13 @@ function setupOpenTelemetry({
 	// the LOG_LEVEL environment variable) takes over. We set the
 	// OpenTelemetry log level to the maximum value that we want
 	// Reliability Kit to consider logging
-	diag.setLogger(
+	opentelemetrySDK.api.diag.setLogger(
 		// @ts-ignore this complains because DiagLogger accepts a type
 		// of unknown whereas our logger is stricter. This is fine though,
 		// if something unknown is logged then we do our best with it.
 		// It's easier to ignore this error than fix it.
 		logger.createChildLogger({ event: 'OTEL_INTERNALS' }),
-		DiagLogLevel.INFO
+		opentelemetrySDK.api.DiagLogLevel.INFO
 	);
 
 	// Set up and start OpenTelemetry

packages/opentelemetry/lib/index.js

@@ -20,16 +20,12 @@
 		"@dotcom-reliability-kit/errors": "^3.1.0",
 		"@dotcom-reliability-kit/log-error": "^4.1.1",
 		"@dotcom-reliability-kit/logger": "^3.1.1",
-		"@opentelemetry/api": "^1.8.0",
 		"@opentelemetry/auto-instrumentations-node": "^0.46.1",
 		"@opentelemetry/exporter-metrics-otlp-proto": "^0.51.1",
 		"@opentelemetry/exporter-trace-otlp-proto": "^0.51.1",
 		"@opentelemetry/host-metrics": "^0.35.1",
 		"@opentelemetry/instrumentation-runtime-node": "^0.4.0",
-		"@opentelemetry/resources": "^1.24.1",
-		"@opentelemetry/sdk-metrics": "^1.24.1",
 		"@opentelemetry/sdk-node": "^0.51.1",
-		"@opentelemetry/sdk-trace-base": "^1.24.1",
 		"@opentelemetry/semantic-conventions": "^1.24.1"
 	}
 }

packages/opentelemetry/package.json

@@ -1,6 +1,6 @@
 jest.mock('@opentelemetry/exporter-metrics-otlp-proto');
 jest.mock('@opentelemetry/otlp-exporter-base');
-jest.mock('@opentelemetry/sdk-metrics');
+jest.mock('@opentelemetry/sdk-node');
 jest.mock('@dotcom-reliability-kit/logger');
 jest.mock('../../../../lib/config/user-agents', () => ({
 	METRICS_USER_AGENT: 'mock-metrics-user-agent'
@@ -10,7 +10,8 @@ const logger = require('@dotcom-reliability-kit/logger');
 const {
 	OTLPMetricExporter
 } = require('@opentelemetry/exporter-metrics-otlp-proto');
-const { PeriodicExportingMetricReader } = require('@opentelemetry/sdk-metrics');
+const { PeriodicExportingMetricReader } =
+	require('@opentelemetry/sdk-node').metrics;
 const { createMetricsConfig } = require('../../../../lib/config/metrics');
 
 describe('@dotcom-reliability-kit/opentelemetry/lib/config/metrics', () => {

packages/opentelemetry/test/unit/lib/config/metrics.spec.js

@@ -16,7 +16,7 @@ jest.mock('@dotcom-reliability-kit/app-info', () => ({
 		}
 	}
 }));
-jest.mock('@opentelemetry/resources');
+jest.mock('@opentelemetry/sdk-node');
 jest.mock('@opentelemetry/semantic-conventions', () => ({
 	SEMRESATTRS_CLOUD_PROVIDER: 'mock-semresattrs-cloud-provider',
 	SEMRESATTRS_CLOUD_REGION: 'mock-semresattrs-cloud-region',
@@ -26,7 +26,7 @@ jest.mock('@opentelemetry/semantic-conventions', () => ({
 	SEMRESATTRS_SERVICE_INSTANCE_ID: 'mock-semresattrs-service-instance-id'
 }));
 
-const { Resource } = require('@opentelemetry/resources');
+const { Resource } = require('@opentelemetry/sdk-node').resources;
 const { createResourceConfig } = require('../../../../lib/config/resource');
 
 describe('@dotcom-reliability-kit/opentelemetry/lib/config/resource', () => {

packages/opentelemetry/test/unit/lib/config/resource.spec.js

@@ -9,10 +9,8 @@ const logger = require('@dotcom-reliability-kit/logger');
 const {
 	OTLPTraceExporter
 } = require('@opentelemetry/exporter-trace-otlp-proto');
-const {
-	NoopSpanProcessor,
-	TraceIdRatioBasedSampler
-} = require('@opentelemetry/sdk-trace-base');
+const { NoopSpanProcessor, TraceIdRatioBasedSampler } =
+	require('@opentelemetry/sdk-node').tracing;
 const { createTracingConfig } = require('../../../../lib/config/tracing');
 
 describe('@dotcom-reliability-kit/opentelemetry/lib/config/tracing', () => {

packages/opentelemetry/test/unit/lib/config/tracing.spec.js

@@ -1,5 +1,4 @@
 jest.mock('@opentelemetry/sdk-node');
-jest.mock('@opentelemetry/api');
 jest.mock('@dotcom-reliability-kit/logger');
 jest.mock('../../../lib/config/instrumentations', () => ({
 	createInstrumentationConfig: jest
@@ -22,7 +21,7 @@ const {
 const { createMetricsConfig } = require('../../../lib/config/metrics');
 const { createResourceConfig } = require('../../../lib/config/resource');
 const { createTracingConfig } = require('../../../lib/config/tracing');
-const { diag, DiagLogLevel } = require('@opentelemetry/api');
+const { diag, DiagLogLevel } = require('@opentelemetry/sdk-node').api;
 const { NodeSDK } = require('@opentelemetry/sdk-node');
 const logger = require('@dotcom-reliability-kit/logger');