fix: make FetchResponse type compatible with a native Response object #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaleslimghost
commented
May 1, 2024
| @@ -25,7 +25,7 @@ const { Writable } = require('node:stream'); | |||
| * The response HTTP status code. | |||
| * @property {string} url | |||
| * The URL of the response. | |||
| * @property {FetchResponseBody} body | |||
| * @property {NodeFetchResponseBody | ReadableStream<Uint8Array> | null} body | |||
There was a problem hiding this comment.
ReadableStream here is the native web streams type, which comes from the DOM lib types. i'm not 100% certain how this will behave if the consumer doesn't have that lib.
There was a problem hiding this comment.
actually this seems to work fine in cp-content-pipeline-schema
apaleslimghost
force-pushed
the
apaleslimghost-patch-1
branch
from
b3b0e2a to
d4efd92
Compare
This is why we've missed a few type errors.
CyntiBinti
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.