Refactor the OpenTelemetry package #1066
Conversation
rowanmanning
added
the
package: opentelemetry
This also deprecates the top-level `authorizationHeader` option in favour of one under `tracing`. This is because we won't be using the same header for metrics.
rowanmanning
force-pushed
the
opentelemetry-refactor
branch
from
7cff94c to
39b3c99
Compare
There was a problem hiding this comment.
Nice, splitting this out into different bits in lib/ makes it more clear.
Question: did you want to update the use of appInfo to the new changes you added in #1082?
Non-blocking but I am slightly confused by the move of options.authorizationHeader to options.tracing.authorizationHeader but then you've kept the same environment variable of OPENTELEMETRY_AUTHORIZATION_HEADER which suggests that we will be sharing it between traces and metrics?
Yep I'll do that in a later PR, didn't want to delay this one.
I couldn't be bothered to try and change the name of that one yet. I may deprecate this environment variable and switch to |
This refactors the package, splitting things into more testable modules ahead of adding in metrics support. I tried adding support already but the tests get unwieldy and it was difficult to reason about anything; I took a step back and did some refactoring which will make adding metrics a lot easier.
I tested this manually as well by linking it into a local project and testing that traces come through in Jaeger.