Broad app info improvements (required for OpenTelemetry metrics) #1082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanmanning
changed the title
alexmuller
approved these changes
Jun 12, 2024
|
Yep, this is what EDO and OpenTelemetry advices as well, if there is no real instance ID then it should be unique to the running process. We may be able to find other IDs in environment variables later for different platforms |
This makes our calculation of system version a lot more solid. This is going to be required for OpenTelemetry metrics, because any metric sent without a version will end up in the Dead Letter metrics. Because of this I want to give users of Reliability Kit more of a guarantee that their metrics will arrive.
This adds aliases for a bunch of app-info properties that align with OpenTelemetry's Semantic Conventions. This closes #818.
This is going to be required to send OpenTelemetry metrics as our systems will only accept metrics with the corresponding semantic resource attribute.
rowanmanning
force-pushed
the
broad-app-info-improvements
branch
from
a75abcb to
f64c538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all required to add OpenTelemetry metrics, we need to solidify the app info properties that we rely on otherwise our metrics are rejected. This does the following:
releaseVersionproperty, required in our metricsinstanceIdproperty, required in our metrics