Add more manual type declarations #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanmanning
force-pushed
the
more-manual-type-declarations
branch
from
565de22 to
ca15d42
Compare
We don't recommend interop and it's deprecated, I'm fine not testing against these any more.
This ensures that the correct type definitions are created.
rowanmanning
force-pushed
the
more-manual-type-declarations
branch
from
ca15d42 to
045b483
Compare
CyntiBinti
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds manual type declarations for crash-handler, opentelemetry, errors, and log-error (see #946). I'm also removing some of the module type tests that are no longer required.
Because the
opentelemetry,log-error, anderrorsmodules don't use default exports, we don't need type tests for them. Default exports are the key issue across the library.