Add the final manual type declarations #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the final package we need to add manual type declarations for, it's also the most complex but I decided to just replicate the existing generated types. Because we no longer need a build step I'm removing all of the build-related tooling and updating the documentation accordingly. Resolves #946
Now that we've got manual type declarations we can _finally_ safely migrate to TypeScript 5.5. Phew.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds type declarations to the final package: it's the most complex but I decided to just replicate the existing generated types. Because we no longer need a build step I'm removing all of the build-related tooling and updating the documentation accordingly.
This unlocks the ability to migrate to TypeScript 5.5 which is also included in this PR. It may be easier to review each commit separately because the second one moves types into
@importstatements across the board.This resolves #946.