Mark fetch-error-handler as stable #1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This library has been used in production for months and is now serving as a replacement for the deprecated `n-fetch` and `n-eager-fetch` libraries. There have been no reported issues, it's installed in 9 production systems (including content pipeline), and we're seeing ~2m errors per week in Splunk that were successfully handled by this library: ``` index IN (heroku, aws_cloudwatch) (error.code=FETCH_* OR error.cause.code=FETCH_*) ``` Release-As: 1.0.0
CyntiBinti
reviewed
Jan 30, 2025
There was a problem hiding this comment.
Looks good. Just 1 suggestion that the package.json version should be bumped to stable?
|
Nope not yet - Release Please will open a PR to update the CHANGELOG and package.json files :) |
CyntiBinti
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library has been used in production for months and is now serving as a replacement for the deprecated
n-fetchandn-eager-fetchlibraries.There have been no reported issues, it's installed in 9 production systems (including content pipeline), and we're seeing ~2m errors per week in Splunk that were successfully handled by this library: