feat: manage bad requests with 'allow request methods' package #1325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyntiBinti
requested review from
next-team,
ft-dependency-auto-merger and
a team
as code owners
CyntiBinti
force-pushed
the
cprel-1276
branch
from
129ba54 to
a9bc6fe
Compare
CyntiBinti
commented
Feb 4, 2025
rowanmanning
reviewed
Feb 5, 2025
CyntiBinti
force-pushed
the
cprel-1276
branch
from
e5aac2a to
d0fd723
Compare
CyntiBinti
force-pushed
the
cprel-1276
branch
from
d0fd723 to
ec5a2db
Compare
rowanmanning
approved these changes
Feb 11, 2025
Current behaviour: a DDoS can use an unexpected HTTP method to bypass the Fastly cache and cause interruption to service. For example, making a request to the homepage as a POST rather than a GET. Express will return a 404 for this error. Ideal future work: If we can transform this 404 error into a 405 Method Not Allowed, we may be able to use Signal Sciences to block this kind of attack very quickly. This is because it’s highly unlikely that a genuine user will accidentally make a POST request. Definition of done for this ticket: Build and release a package containing an Express middleware that applications can consume which will cause unexpected request methods to error with a 405 rather than a 404. See Also: [CPREL-1276]
CyntiBinti
force-pushed
the
cprel-1276
branch
from
26d8206 to
00436e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour: a DDoS can use an unexpected HTTP method to bypass the Fastly cache and cause interruption to service. For example, making a request to the homepage as a POST rather than a GET. Express will return a 404 for this error.
Ideal future work: If we can transform this 404 error into a 405 Method Not Allowed, we may be able to use Signal Sciences to block this kind of attack very quickly. This is because it’s highly unlikely that a genuine user will accidentally make a POST request.
Definition of done for this ticket: Build and release a package containing an Express middleware that applications can consume which will cause unexpected request methods to error with a 405 rather than a 404.
Inspo: https://github.com/rowanmanning/allow-methods/blob/main/index.js
To-Do:
See Also: CPREL-1276