Skip to content

test: wait for logs to appear in end-to-end test #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

test: wait for logs to appear in end-to-end test #1332

merged 1 commit into from
Feb 13, 2025

Conversation

rowanmanning
Copy link
Member

No description provided.

@rowanmanning rowanmanning force-pushed the fix-flaky-test branch 2 times, most recently from a7cf102 to 675e955 Compare February 13, 2025 10:53
@rowanmanning rowanmanning changed the title WIP fix some flaky tests test: wait for logs to appear in end-to-end test Feb 13, 2025
@rowanmanning rowanmanning force-pushed the fix-flaky-test branch 2 times, most recently from 99f31f2 to 40490d0 Compare February 13, 2025 10:55
@rowanmanning rowanmanning marked this pull request as ready for review February 13, 2025 10:55
@rowanmanning rowanmanning requested a review from a team as a code owner February 13, 2025 10:55
@rowanmanning rowanmanning enabled auto-merge (rebase) February 13, 2025 10:56
@rowanmanning rowanmanning enabled auto-merge (rebase) February 13, 2025 12:25
CyntiBinti
CyntiBinti approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@CyntiBinti CyntiBinti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay 😁

@rowanmanning
test: wait for logs to appear in end-to-end test
55caf31 
This test has been very flaky, I think this is because Pino uses async
logs and sometimes the log doesn't appear immediately. This should
address the race condition where our tests run before the log has had
time to come through.
@rowanmanning rowanmanning merged commit 1014779 into main Feb 13, 2025
11 checks passed
@rowanmanning rowanmanning deleted the fix-flaky-test branch February 13, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyntiBinti CyntiBinti CyntiBinti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rowanmanning @CyntiBinti