-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Normalise environment string captured by app info package #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3c196aa
to
89146fc
Compare
The FT may use multiple values across different platforms to indicate the environment that an app is running in. For example, AWS resources may be assigned an environment variable named ENVIRONMENT with the value "p" which is short for "production".
89146fc
to
e6f8cbd
Compare
Been thinking about this properly and I wonder whether this is a breaking change? We're currently doing no validation based on this and so it's possible systems have their own checks like
|
Little bit tangental, but in my thinking on this I've felt that there's a missing attribute needed in order to allow us to normalise the deployment environment values (which I'd love to do). Something like |
Oh looks like the Which does sort of leave room for a ID attribute or something. |
If the property is a documented part of a public interface then I reckon this must be a breaking change 👍
This would resolve the issue we're having. As production/prod/p is as close to a standard as we get at the FT I assume this change would help implementors towards the expected behaviour and not be surprising.
Then perhaps we do go for the above and a major version bump is saved for adding lots of value for people to upgrade to. |
OK cool 👍 then we'll do the following:
|
This disables log prettification if the environment is either `prod` or `p`, which we use across some systems. This is done in the logger rather than app-info because that would be a breaking change. If app-info normalises the environment in a later version then we can switch logger back to expecting `production` only. Co-Authored-By: Matt Hinchliffe <i-like-robots@users.noreply.github.com> See-also: #1368
Closing in favour of #1373 |
This disables log prettification if the environment is either `prod` or `p`, which we use across some systems. This is done in the logger rather than app-info because that would be a breaking change. If app-info normalises the environment in a later version then we can switch logger back to expecting `production` only. Co-Authored-By: Matt Hinchliffe <i-like-robots@users.noreply.github.com> See-also: #1368
This disables log prettification if the environment is either `prod` or `p`, which we use across some systems. This is done in the logger rather than app-info because that would be a breaking change. If app-info normalises the environment in a later version then we can switch logger back to expecting `production` only. Co-Authored-By: Matt Hinchliffe <i-like-robots@users.noreply.github.com> See-also: #1368
This disables log prettification if the environment is either `prod` or `p`, which we use across some systems. This is done in the logger rather than app-info because that would be a breaking change. If app-info normalises the environment in a later version then we can switch logger back to expecting `production` only. Co-Authored-By: Matt Hinchliffe <i-like-robots@users.noreply.github.com> See-also: #1368
The FT may use multiple values across different platforms to indicate the environment that an app is running in. For example, AWS resources may be assigned an environment variable named
ENVIRONMENT
and the value"p"
which is short for"production"
.Follows #1112 (specifically this comment)