feat: disable prettifier for more prod env names #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanmanning
force-pushed
the
logger-production-environments
branch
from
1721298 to
5e190d9
Compare
CyntiBinti
approved these changes
Mar 27, 2025
This disables log prettification if the environment is either `prod` or `p`, which we use across some systems. This is done in the logger rather than app-info because that would be a breaking change. If app-info normalises the environment in a later version then we can switch logger back to expecting `production` only. Co-Authored-By: Matt Hinchliffe <i-like-robots@users.noreply.github.com> See-also: #1368
rowanmanning
force-pushed
the
logger-production-environments
branch
from
5e190d9 to
cc72f9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables log prettification if the environment is either
prodorp, which we use across some systems. This is done in the logger rather than app-info because that would be a breaking change. If app-info normalises the environment in a later version then we can switch logger back to expectingproductiononly.See-also: #1368