chore: migrate to Express v5 in the tests #1416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanmanning
requested review from
next-team,
ft-dependency-auto-merger and
a team
as code owners
CyntiBinti
approved these changes
May 8, 2025
This moves us to use Express v5 in the tests. Only OpenTelemetry needed a little more work and I believe this is because async routing is now properly supported in Express. It means that we can no longer shut down the OpenTelemetry SDK _before_ the response has been sent, because the trace is sent on response close rather than once the middleware finishes executing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves us to use Express v5 in the tests. Only OpenTelemetry needed a little more work and I believe this is because async routing is now properly supported in Express. It means that we can no longer shut down the OpenTelemetry SDK before the response has been sent, because the trace is sent on response close rather than once the middleware finishes executing.