feat: remove legacy subscription view

Drops the legacy subscription view, which was marked as legacy ~3 years ago.
Given the long time, lack of updates since, it should be safe to remove.
This further reduces the amount of 'unnecessary' options.

Ref: libre-tube#7276
Ref: libre-tube@298023b
Closes: libre-tube#7403

Author: FineFindus

app/src/main/java/com/github/libretube/constants/PreferenceKeys.kt

@@ -26,8 +26,6 @@ object PreferenceKeys {
     const val GRID_COLUMNS_LANDSCAPE = "grid_landscape"
     const val LABEL_VISIBILITY = "label_visibility"
     const val APP_ICON = "icon_change"
-    const val LEGACY_SUBSCRIPTIONS = "legacy_subscriptions"
-    const val LEGACY_SUBSCRIPTIONS_COLUMNS = "legacy_subscriptions_columns"
     const val NEW_VIDEOS_BADGE = "new_videos_badge"
     const val PLAYLISTS_ORDER = "playlists_order"
     const val PLAYLIST_SORT_ORDER = "playlist_sort_order"

app/src/main/java/com/github/libretube/ui/adapters/LegacySubscriptionAdapter.kt

@@ -30,7 +30,6 @@ import com.github.libretube.helpers.NavBarHelper
 import com.github.libretube.helpers.NavigationHelper
 import com.github.libretube.helpers.PreferenceHelper
 import com.github.libretube.obj.SelectableOption
-import com.github.libretube.ui.adapters.LegacySubscriptionAdapter
 import com.github.libretube.ui.adapters.SubscriptionChannelAdapter
 import com.github.libretube.ui.adapters.VideoCardsAdapter
 import com.github.libretube.ui.base.DynamicLayoutManagerFragment
@@ -81,7 +80,6 @@ class SubscriptionsFragment : DynamicLayoutManagerFragment(R.layout.fragment_sub
             field = value
         }
 
-    private val legacySubscriptionsAdapter = LegacySubscriptionAdapter()
     private val channelsAdapter = SubscriptionChannelAdapter()
 
     override fun setLayoutManagers(gridItems: Int) {
@@ -97,24 +95,8 @@ class SubscriptionsFragment : DynamicLayoutManagerFragment(R.layout.fragment_sub
 
         binding.subFeed.adapter = feedAdapter
 
-        val legacySubscriptions = PreferenceHelper.getBoolean(
-            PreferenceKeys.LEGACY_SUBSCRIPTIONS,
-            false
-        )
-
-        if (legacySubscriptions) {
-            binding.subChannels.layoutManager = GridLayoutManager(
-                context,
-                PreferenceHelper.getString(
-                    PreferenceKeys.LEGACY_SUBSCRIPTIONS_COLUMNS,
-                    "3"
-                ).toInt()
-            )
-            binding.subChannels.adapter = legacySubscriptionsAdapter
-        } else {
-            binding.subChannels.layoutManager = LinearLayoutManager(context)
-            binding.subChannels.adapter = channelsAdapter
-        }
+        binding.subChannels.layoutManager = LinearLayoutManager(context)
+        binding.subChannels.adapter = channelsAdapter
 
         // Check if the AppBarLayout is fully expanded
         binding.subscriptionsAppBar.addOnOffsetChangedListener { _, verticalOffset ->
@@ -426,13 +408,8 @@ class SubscriptionsFragment : DynamicLayoutManagerFragment(R.layout.fragment_sub
         val subscriptions =
             viewModel.subscriptions.value?.filterByGroup(selectedFilterGroup) ?: return
 
-        val legacySubscriptions = PreferenceHelper.getBoolean(
-            PreferenceKeys.LEGACY_SUBSCRIPTIONS,
-            false
-        )
 
-        val adapter = if (legacySubscriptions) legacySubscriptionsAdapter else channelsAdapter
-        adapter.submitList(subscriptions) {
+        channelsAdapter.submitList(subscriptions) {
             if (restoreScrollState) {
                 binding.subFeed.layoutManager?.onRestoreInstanceState(viewModel.subChannelsRecyclerViewState)
                 binding.subscriptionsAppBar.setExpanded(viewModel.subChannelsRecyclerViewState == null)

app/src/main/java/com/github/libretube/ui/fragments/SubscriptionsFragment.kt

@@ -284,7 +284,6 @@
     <string name="maximum_image_cache">Max image cache size</string>
     <string name="copied_to_clipboard">Copied to clipboard</string>
     <string name="open_copied">Open</string>
-    <string name="legacy_subscriptions">Legacy subscriptions view</string>
     <string name="device_info">Device Info</string>
     <string name="audio_video_summary">Quality and format</string>
     <string name="delete">Delete from downloads</string>

app/src/main/res/values/strings.xml

@@ -84,24 +84,4 @@
 
     </PreferenceCategory>
 
-    <PreferenceCategory
-        app:title="@string/legacy_subscriptions">
-
-        <SwitchPreferenceCompat
-            app:defaultValue="false"
-            app:icon="@drawable/ic_list"
-            app:key="legacy_subscriptions"
-            app:title="@string/legacy_subscriptions" />
-
-        <ListPreference
-            android:entries="@array/grid"
-            android:entryValues="@array/grid"
-            app:defaultValue="3"
-            app:icon="@drawable/ic_grid"
-            app:dependency="legacy_subscriptions"
-            app:key="legacy_subscriptions_columns"
-            app:title="@string/grid" />
-
-    </PreferenceCategory>
-
 </PreferenceScreen>