feat: added-types

Author: Zaimwa9

api/segments/models.py

@@ -5,6 +5,7 @@
 
 from django.conf import settings
 from django.contrib.contenttypes.fields import GenericRelation
+from django.contrib.contenttypes.models import ContentType
 from django.core.exceptions import ValidationError
 from django.db import models
 from django_lifecycle import (  # type: ignore[import-untyped]
@@ -14,7 +15,7 @@
     hook,
 )
 from flag_engine.segments import constants
-from django.contrib.contenttypes.models import ContentType
+
 from audit.constants import (
     SEGMENT_CREATED_MESSAGE,
     SEGMENT_DELETED_MESSAGE,
@@ -164,7 +165,11 @@ def clone_segment_rules(self, cloned_segment: "Segment") -> list["SegmentRule"]:
     def clone_segment_metadata(self, cloned_segment: "Segment") -> list["Metadata"]:
         cloned_metadata = []
         for metadata in self.metadata.all():
-            cloned_metadata.append(metadata.deep_clone_for_new_entity(cloned_segment, ContentType.objects.get_for_model(cloned_segment)))
+            cloned_metadata.append(
+                metadata.deep_clone_for_new_entity(
+                    cloned_segment, ContentType.objects.get_for_model(cloned_segment)
+                )
+            )
         cloned_segment.refresh_from_db()
         assert (
             len(self.metadata.all())
@@ -174,7 +179,6 @@ def clone_segment_metadata(self, cloned_segment: "Segment") -> list["Metadata"]:
 
         return cloned_metadata
 
-
     def clone(self, name: str) -> "Segment":
         cloned_segment = Segment(
             name=name,

api/segments/serializers.py

@@ -1,7 +1,9 @@
-from rest_framework import serializers
 from typing import Any, cast
-from segments.models import Segment
+
 from common.segments.serializers import SegmentSerializer
+from rest_framework import serializers
+
+from segments.models import Segment
 
 
 class SegmentSerializerBasic(serializers.ModelSerializer):  # type: ignore[type-arg]
@@ -21,20 +23,21 @@ class SegmentListQuerySerializer(serializers.Serializer):  # type: ignore[type-a
     )
     include_feature_specific = serializers.BooleanField(required=False, default=True)
 
+
 class CloneSegmentSerializer(SegmentSerializer):
     class Meta:
         model = Segment
-        fields = ("name", )
+        fields = ("name",)
 
-    def validate(self, attrs: dict[str, Any]) -> dict[str,Any]:
+    def validate(self, attrs: dict[str, Any]) -> dict[str, Any]:
         if not attrs.get("name"):
             raise serializers.ValidationError("Name is required to clone a segment")
         return attrs
 
-    def create(self, validated_data: dict[str, Any]) -> Segment: 
+    def create(self, validated_data: dict[str, Any]) -> Segment:
         name = validated_data.get("name")
         source_segment = self.context.get("source_segment")
-        assert source_segment is not None, "Source segment is required to clone a segment"
-        return cast(Segment, source_segment.clone(
-            name
-        ))
+        assert source_segment is not None, (
+            "Source segment is required to clone a segment"
+        )
+        return cast(Segment, source_segment.clone(name))

api/segments/views.py

@@ -1,14 +1,16 @@
 import logging
+from typing import Any
 
 from common.projects.permissions import VIEW_PROJECT
 from common.segments.serializers import (
     SegmentSerializer,
 )
 from django.utils.decorators import method_decorator
 from drf_yasg.utils import swagger_auto_schema  # type: ignore[import-untyped]
-from rest_framework import viewsets, status
+from rest_framework import status, viewsets
 from rest_framework.decorators import action, api_view
 from rest_framework.generics import get_object_or_404
+from rest_framework.request import Request
 from rest_framework.response import Response
 
 from app.pagination import CustomPagination
@@ -29,9 +31,6 @@
     SegmentListQuerySerializer,
 )
 
-from rest_framework.request import Request
-from typing import Any
-
 logger = logging.getLogger()
 
 
@@ -125,15 +124,21 @@ def associated_features(self, request, *args, **kwargs):  # type: ignore[no-unty
         serializer = self.get_serializer(queryset, many=True)
         return Response(serializer.data)
 
-    @swagger_auto_schema(request_body=CloneSegmentSerializer, responses={201: SegmentSerializer()}, method="post") # type: ignore[misc]
+    @swagger_auto_schema(
+        request_body=CloneSegmentSerializer,
+        responses={201: SegmentSerializer()},
+        method="post",
+    )  # type: ignore[misc]
     @action(
         detail=True,
         methods=["POST"],
         url_path="clone",
         serializer_class=CloneSegmentSerializer,
     )
     def clone(self, request: Request, *args: Any, **kwargs: Any) -> Response:
-        serializer = CloneSegmentSerializer(data=request.data, context={"source_segment": self.get_object()})
+        serializer = CloneSegmentSerializer(
+            data=request.data, context={"source_segment": self.get_object()}
+        )
         serializer.is_valid(raise_exception=True)
         clone = serializer.save()
         return Response(SegmentSerializer(clone).data, status=status.HTTP_201_CREATED)

api/tests/unit/segments/test_unit_segments_views.py

@@ -1500,7 +1500,7 @@ def test_include_feature_specific_query_filter__false(
     [
         (lazy_fixture("segment")),
         (lazy_fixture("feature_specific_segment")),
-    ]
+    ],
 )
 def test_clone_segment(
     project: Project,
@@ -1509,8 +1509,7 @@ def test_clone_segment(
 ) -> None:
     # Given
     url = reverse(
-        "api-v1:projects:project-segments-clone",
-        args=[project.id, source_segment.id]
+        "api-v1:projects:project-segments-clone", args=[project.id, source_segment.id]
     )
     new_segment_name = "cloned_segment"
     data = {
@@ -1520,12 +1519,12 @@ def test_clone_segment(
         segment=source_segment,  # attach to source_segment instead of using fixture
         type=SegmentRule.ALL_RULE,
     )
-    
+
     sub_rule = SegmentRule.objects.create(
         rule=segment_rule,
         type=SegmentRule.ALL_RULE,
     )
-    
+
     created_condition = Condition.objects.create(
         rule=sub_rule,
         property="foo",
@@ -1536,19 +1535,17 @@ def test_clone_segment(
 
     # When
     response = admin_client.post(
-        url,
-        data=json.dumps(data),
-        content_type="application/json"
+        url, data=json.dumps(data), content_type="application/json"
     )
 
     # Then
     assert response.status_code == status.HTTP_201_CREATED
-    
+
     response_data = response.json()
     assert response_data["name"] == new_segment_name
     assert response_data["project"] == project.id
     assert response_data["id"] != source_segment.id
-    
+
     # Testing cloned segment main attributes
     cloned_segment = Segment.objects.get(id=response_data["id"])
     assert cloned_segment.name == new_segment_name
@@ -1564,14 +1561,13 @@ def test_clone_segment(
 
     cloned_top_rule = cloned_segment.rules.first()
     cloned_sub_rule = cloned_top_rule.rules.first()
-    
+
     assert cloned_top_rule.type == segment_rule.type
     assert cloned_sub_rule.type == segment_rule.type
 
     # Testing cloning of sub-rules conditions
     cloned_condition = cloned_sub_rule.conditions.first()
-    
+
     assert cloned_condition.property == created_condition.property
     assert cloned_condition.operator == created_condition.operator
     assert cloned_condition.value == created_condition.value
-