Skip to content

feat: Add product version to API response headers #5366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 28, 2025
Merged

feat: Add product version to API response headers #5366

merged 11 commits into from
Apr 28, 2025

Conversation

emyller
Copy link
Contributor

@emyller emyller commented Apr 22, 2025 •
edited
Loading

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

ref: #4253

  • Read the release Git tag into an environment variable, then into Django settings.
  • Introduce a middleware that adds X-Flagsmith-Version to all responses.

How did you test this code?

Functional tests.

@vercel Vercel
Copy link

vercel bot commented Apr 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Apr 28, 2025 9:17pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Apr 28, 2025 9:17pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Apr 28, 2025 9:17pm

@github-actions github-actions bot added the api Issue related to the REST API label Apr 22, 2025
@emyller emyller changed the title feat/add-version-to-response-headers feat: Add version to response headers Apr 22, 2025
@emyller emyller changed the title feat: Add version to response headers feat: Add product version to response headers Apr 22, 2025
@emyller emyller changed the title feat: Add product version to response headers feat: Add product version to API response headers Apr 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025 •
edited
Loading

Uffizzi Preview deployment-63002 was deleted.

@emyller
Copy link
Contributor Author

emyller commented Apr 22, 2025

Messed up GitHub references.

@emyller emyller closed this Apr 22, 2025
@emyller emyller deleted the feat/add-version-to-response-headers branch April 22, 2025 00:16
@emyller emyller restored the feat/add-version-to-response-headers branch April 22, 2025 00:22
@emyller emyller reopened this Apr 22, 2025
@emyller emyller self-assigned this Apr 22, 2025
@github-actions github-actions bot added the feature New feature or request label Apr 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025 •
edited
Loading

Uffizzi Preview deployment-63161 was deleted.

matthewelwell
matthewelwell reviewed Apr 22, 2025
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach and tests look fine to me.

@khvn26
Copy link
Member

khvn26 commented Apr 22, 2025

I have a hunch this belongs to https://github.com/flagsmith/flagsmith-common, as the implementation is likely going to be a global middleware

@emyller emyller force-pushed the feat/add-version-to-response-headers branch from 234e838 to 299d2b1 Compare April 23, 2025 14:37
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 23, 2025
@emyller emyller force-pushed the feat/add-version-to-response-headers branch from cced72e to 072190e Compare April 23, 2025 17:21
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 23, 2025
@emyller emyller force-pushed the feat/add-version-to-response-headers branch from a7ddcde to 0e60dd7 Compare April 23, 2025 19:50
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 23, 2025
@emyller emyller force-pushed the feat/add-version-to-response-headers branch from 1b3a852 to 7d77707 Compare April 23, 2025 20:26
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 23, 2025
@emyller emyller force-pushed the feat/add-version-to-response-headers branch from 0be60f7 to 27f5e17 Compare April 25, 2025 17:08
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 25, 2025
@emyller emyller force-pushed the feat/add-version-to-response-headers branch from 27f5e17 to 256a9e2 Compare April 25, 2025 17:24
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 25, 2025
@emyller emyller force-pushed the feat/add-version-to-response-headers branch from 256a9e2 to 058ff61 Compare April 28, 2025 14:43
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 28, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 28, 2025
@emyller emyller merged commit 0cfe793 into main Apr 28, 2025
38 checks passed
@emyller emyller deleted the feat/add-version-to-response-headers branch April 28, 2025 21:53
@flagsmithdev flagsmithdev mentioned this pull request Apr 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khvn26 khvn26 khvn26 left review comments

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees

@emyller emyller

Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emyller @khvn26 @matthewelwell