Skip to content

fix: validate-returns-empty-trait-list-if-persistence-false #5398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Apr 29, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • returns empty traits list instead of 400 if trait_persistence_allowed is false

How did you test this code?

  • Added unit test

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner April 29, 2025 07:24
@Zaimwa9 Zaimwa9 requested review from matthewelwell and removed request for a team April 29, 2025 07:24
Copy link

vercel bot commented Apr 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2025 7:26am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2025 7:26am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2025 7:26am

@github-actions github-actions bot added the api Issue related to the REST API label Apr 29, 2025
@github-actions github-actions bot added the fix label Apr 29, 2025
Copy link
Contributor

github-actions bot commented Apr 29, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5398 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5398 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5398 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5398 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5398 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5398 Finished ✅ Results

@Zaimwa9 Zaimwa9 closed this Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant