Skip to content

feat: track welcome page tasks and integrations #5500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jun 4, 2025

Conversation

Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented May 28, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Please describe.

How did you test this code?

Please describe.

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner May 28, 2025 08:52
@Zaimwa9 Zaimwa9 requested review from gagantrivedi and removed request for a team May 28, 2025 08:52
@Zaimwa9 Zaimwa9 marked this pull request as draft May 28, 2025 08:52
Copy link

vercel bot commented May 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2025 2:16pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2025 2:16pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2025 2:16pm

@github-actions github-actions bot added the api Issue related to the REST API label May 28, 2025
@github-actions github-actions bot added the feature New feature or request label May 28, 2025
Copy link
Contributor

github-actions bot commented May 28, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5500 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5500 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5500 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5500 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5500 Finished ✅ Results

Copy link
Contributor

github-actions bot commented May 28, 2025

Uffizzi Ephemeral Environment Deploying

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5500

⚙️ Updating now by workflow run 15319661974.

What is Uffizzi? Learn more!

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels May 28, 2025
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (facb008) to head (88fb440).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5500      +/-   ##
==========================================
+ Coverage   97.65%   97.68%   +0.02%     
==========================================
  Files        1237     1240       +3     
  Lines       43492    43965     +473     
==========================================
+ Hits        42474    42946     +472     
- Misses       1018     1019       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Zaimwa9 Zaimwa9 marked this pull request as ready for review May 28, 2025 12:59
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels May 28, 2025
@Zaimwa9 Zaimwa9 requested a review from khvn26 May 29, 2025 08:48
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 2, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 2, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 2, 2025
@Zaimwa9 Zaimwa9 assigned gagantrivedi and unassigned khvn26 Jun 3, 2025
@Zaimwa9 Zaimwa9 requested a review from gagantrivedi June 3, 2025 09:39
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 3, 2025
@flagsmith flagsmith bot added the flagsmith flag The Issue/PR has a linked feaature flag in Flagsmith label Jun 3, 2025
Copy link

flagsmith bot commented Jun 3, 2025

Flagsmith feature linked: integration_onboarding
Default Values:

Environment Enabled Value Last Updated (UTC)
Production ❌ Disabled 2025-06-03 15:45:36
Staging ❌ Disabled 2025-06-03 15:45:36
Demo ❌ Disabled 2025-06-03 15:45:36
Self hosted defaults ❌ Disabled 2025-06-03 15:45:36
Demo2 ❌ Disabled 2025-06-03 15:45:36

Copy link

flagsmith bot commented Jun 3, 2025

Flagsmith Feature integration_onboarding has been updated:

Environment Enabled Value Last Updated (UTC)
Staging ✅ Enabled 2025-06-03 15:53:17

@Zaimwa9 Zaimwa9 requested a review from gagantrivedi June 4, 2025 07:29
Copy link
Member

@gagantrivedi gagantrivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from minor type hint nit

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 4, 2025
@Zaimwa9 Zaimwa9 merged commit e8b2738 into main Jun 4, 2025
30 checks passed
@Zaimwa9 Zaimwa9 deleted the feat/track-welcome-page-tasks branch June 4, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request flagsmith flag The Issue/PR has a linked feaature flag in Flagsmith
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants