Support Always Run As Administrator

Flow.Launcher.Infrastructure/UserSettings/Settings.cs

@@ -372,6 +372,8 @@ public bool HideNotifyIcon
         public bool LeaveCmdOpen { get; set; }
         public bool HideWhenDeactivated { get; set; } = true;
 
+        public bool AlwaysRunAsAdministrator { get; set; } = false;
+
         public bool SearchQueryResultsWithDelay { get; set; }
         public int SearchDelayTime { get; set; } = 150;
 

Flow.Launcher.Infrastructure/Win32Helper.cs

@@ -5,6 +5,7 @@
 using System.Globalization;
 using System.Linq;
 using System.Runtime.InteropServices;
+using System.Security.Principal;
 using System.Threading;
 using System.Threading.Tasks;
 using System.Windows;
@@ -38,7 +39,7 @@
         {
             var cloaked = cloak ? 1 : 0;
 
             return PInvoke.DwmSetWindowAttribute(
                 GetWindowHandle(window),
                 DWMWINDOWATTRIBUTE.DWMWA_CLOAK,
                 &cloaked,
@@ -50,12 +51,12 @@
             var backdropType = backdrop switch
             {
                 BackdropTypes.Acrylic => DWM_SYSTEMBACKDROP_TYPE.DWMSBT_TRANSIENTWINDOW,
                 BackdropTypes.Mica => DWM_SYSTEMBACKDROP_TYPE.DWMSBT_MAINWINDOW,
                 BackdropTypes.MicaAlt => DWM_SYSTEMBACKDROP_TYPE.DWMSBT_TABBEDWINDOW,
                 _ => DWM_SYSTEMBACKDROP_TYPE.DWMSBT_AUTO
             };
 
             return PInvoke.DwmSetWindowAttribute(
                 GetWindowHandle(window),
                 DWMWINDOWATTRIBUTE.DWMWA_SYSTEMBACKDROP_TYPE,
                 &backdropType,
@@ -753,5 +754,16 @@
         }
 
         #endregion
+
+        #region Administrator Mode
+
+        public static bool IsAdministrator()
+        {
+            using var identity = WindowsIdentity.GetCurrent();
+            var principal = new WindowsPrincipal(identity);
+            return principal.IsInRole(WindowsBuiltInRole.Administrator);
+        }
+
+        #endregion
     }
 }

Flow.Launcher/App.xaml.cs

@@ -1,5 +1,7 @@
 using System;
 using System.Diagnostics;
+using System.IO;
+using System.Reflection;
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
@@ -236,12 +238,23 @@ private void AutoStartup()
             {
                 try
                 {
-                    Helper.AutoStartup.CheckIsEnabled(_settings.UseLogonTaskForStartup);
+                    Helper.AutoStartup.CheckIsEnabled(_settings.UseLogonTaskForStartup, _settings.AlwaysRunAsAdministrator);
+                }
+                catch (UnauthorizedAccessException)
+                {
+                    // If it fails for permission, we need to ask the user to restart as administrator
+                    if (API.ShowMsgBox(
+                        API.GetTranslation("runAsAdministratorChangeAndRestart"),
+                        API.GetTranslation("runAsAdministratorChange"),
+                        MessageBoxButton.YesNo) == MessageBoxResult.Yes)
+                    {
+                        RestartAppAsAdministrator();
+                    }
                 }
                 catch (Exception e)
                 {
-                    // but if it fails (permissions, etc) then don't keep retrying
-                    // this also gives the user a visual indication in the Settings widget
+                    // But if it fails for other reasons then do not keep retrying,
+                    // set startup to false to give users a visual indication in the general page
                     _settings.StartFlowLauncherOnSystemStartup = false;
                     API.ShowMsg(API.GetTranslation("setAutoStartFailed"), e.Message);
                 }
@@ -319,6 +332,45 @@ private static void RegisterTaskSchedulerUnhandledException()
 
         #endregion
 
+        #region Restart
+
+        // Since Squirrel does not provide a way to restart the app as administrator,
+        // we need to do it manually by starting the update.exe with the runas verb
+        public static void RestartAppAsAdministrator()
+        {
+            var startInfo = new ProcessStartInfo
+            {
+                FileName = getUpdateExe(),
+                Arguments = $"--processStartAndWait {Constant.ExecutablePath}",
+                UseShellExecute = true,
+                Verb = "runas",
+            };
+            Process.Start(startInfo);
+            Thread.Sleep(500);
+            Environment.Exit(0);
+
+            // Local function
+            static string getUpdateExe()
+            {
+                Assembly entryAssembly = Assembly.GetEntryAssembly();
+                if (entryAssembly != null && Path.GetFileName(entryAssembly.Location).Equals("update.exe", StringComparison.OrdinalIgnoreCase) && entryAssembly.Location.IndexOf("app-", StringComparison.OrdinalIgnoreCase) == -1 && entryAssembly.Location.IndexOf("SquirrelTemp", StringComparison.OrdinalIgnoreCase) == -1)
+                {
+                    return Path.GetFullPath(entryAssembly.Location);
+                }
+
+                entryAssembly = Assembly.GetEntryAssembly() ?? Assembly.GetExecutingAssembly();
+                FileInfo fileInfo = new FileInfo(Path.Combine(Path.GetDirectoryName(entryAssembly.Location), "..\\Update.exe"));
+                if (!fileInfo.Exists)
+                {
+                    throw new Exception("Update.exe not found, not a Squirrel-installed app?");
+                }
+
+                return fileInfo.FullName;
+            }
+        }
+
+        #endregion
+
         #region IDisposable
 
         protected virtual void Dispose(bool disposing)

Flow.Launcher/Helper/AutoStartup.cs

@@ -17,18 +17,20 @@ public class AutoStartup
     private const string LogonTaskName = $"{Constant.FlowLauncher} Startup";
     private const string LogonTaskDesc = $"{Constant.FlowLauncher} Auto Startup";
 
-    public static void CheckIsEnabled(bool useLogonTaskForStartup)
+    private static readonly bool _isAdministrator = Win32Helper.IsAdministrator();
+
+    public static void CheckIsEnabled(bool useLogonTaskForStartup, bool alwaysRunAsAdministrator)
     {
         // We need to check both because if both of them are enabled,
         // Hide Flow Launcher on startup will not work since the later one will trigger main window show event
-        var logonTaskEnabled = CheckLogonTask();
+        var logonTaskEnabled = CheckLogonTask(alwaysRunAsAdministrator);
         var registryEnabled = CheckRegistry();
         if (useLogonTaskForStartup)
         {
             // Enable logon task
             if (!logonTaskEnabled)
             {
-                Enable(true);
+                Enable(true, alwaysRunAsAdministrator);
             }
             // Disable registry
             if (registryEnabled)
@@ -41,7 +43,7 @@ public static void CheckIsEnabled(bool useLogonTaskForStartup)
             // Enable registry
             if (!registryEnabled)
             {
-                Enable(false);
+                Enable(false, alwaysRunAsAdministrator);
             }
             // Disable logon task
             if (logonTaskEnabled)
@@ -51,28 +53,53 @@ public static void CheckIsEnabled(bool useLogonTaskForStartup)
         }
     }
 
-    private static bool CheckLogonTask()
+    private static bool CheckLogonTask(bool alwaysRunAsAdministrator)
     {
         using var taskService = new TaskService();
         var task = taskService.RootFolder.AllTasks.FirstOrDefault(t => t.Name == LogonTaskName);
         if (task != null)
         {
             try
             {
-                // Check if the action is the same as the current executable path
-                // If not, we need to unschedule and reschedule the task
                 if (task.Definition.Actions.FirstOrDefault() is Microsoft.Win32.TaskScheduler.Action taskAction)
                 {
                     var action = taskAction.ToString().Trim();
-                    if (!action.Equals(Constant.ExecutablePath, StringComparison.OrdinalIgnoreCase))
+                    var pathCorrect = action.Equals(Constant.ExecutablePath, StringComparison.OrdinalIgnoreCase);
+                    var runLevelCorrect = CheckRunLevel(task.Definition.Principal.RunLevel, alwaysRunAsAdministrator);
+
+                    if (_isAdministrator)
                     {
-                        UnscheduleLogonTask();
-                        ScheduleLogonTask();
+                        // If path or run level is not correct, we need to unschedule and reschedule the task
+                        if (!pathCorrect || !runLevelCorrect)
+                        {
+                            UnscheduleLogonTask();
+                            ScheduleLogonTask(alwaysRunAsAdministrator);
+                        }
+                    }
+                    else
+                    {
+                        // If run level is not correct, we cannot edit it because we are not administrator
+                        if (!runLevelCorrect)
+                        {
+                            throw new UnauthorizedAccessException("Cannot edit task run level because the app is not running as administrator.");
+                        }
+
+                        // If run level is correct and path is not correct, we need to unschedule and reschedule the task
+                        if (!pathCorrect)
+                        {
+                            UnscheduleLogonTask();
+                            ScheduleLogonTask(alwaysRunAsAdministrator);
+                        }
                     }
                 }
 
                 return true;
             }
+            catch (UnauthorizedAccessException e)
+            {
+                App.API.LogError(ClassName, $"Failed to check logon task: {e}");
+                throw; // Throw exception so that App.AutoStartup can show error message
+            }
             catch (Exception e)
             {
                 App.API.LogError(ClassName, $"Failed to check logon task: {e}");
@@ -83,6 +110,11 @@ private static bool CheckLogonTask()
         return false;
     }
 
+    private static bool CheckRunLevel(TaskRunLevel rl, bool alwaysRunAsAdministrator)
+    {
+        return alwaysRunAsAdministrator ? rl == TaskRunLevel.Highest : rl != TaskRunLevel.Highest;
+    }
+
     private static bool CheckRegistry()
     {
         try
@@ -117,16 +149,19 @@ public static void DisableViaLogonTaskAndRegistry()
         Disable(false);
     }
 
-    public static void ChangeToViaLogonTask()
+    public static void ChangeToViaLogonTask(bool alwaysRunAsAdministrator)
     {
         Disable(false);
-        Enable(true);
+        Disable(true); // Remove old logon task so that we can create a new one
+        Enable(true, alwaysRunAsAdministrator);
     }
 
     public static void ChangeToViaRegistry()
     {
         Disable(true);
-        Enable(false);
+        Disable(false); // Remove old registry so that we can create a new one
+        // We do not need to use alwaysRunAsAdministrator for registry, so we just set false here
+        Enable(false, false);
     }
 
     private static void Disable(bool logonTask)
@@ -149,13 +184,13 @@ private static void Disable(bool logonTask)
         }
     }
 
-    private static void Enable(bool logonTask)
+    private static void Enable(bool logonTask, bool alwaysRunAsAdministrator)
     {
         try
         {
             if (logonTask)
             {
-                ScheduleLogonTask();
+                ScheduleLogonTask(alwaysRunAsAdministrator);
             }
             else
             {
@@ -169,14 +204,15 @@ private static void Enable(bool logonTask)
         }
     }
 
-    private static bool ScheduleLogonTask()
+    private static bool ScheduleLogonTask(bool alwaysRunAsAdministrator)
     {
         using var td = TaskService.Instance.NewTask();
         td.RegistrationInfo.Description = LogonTaskDesc;
         td.Triggers.Add(new LogonTrigger { UserId = WindowsIdentity.GetCurrent().Name, Delay = TimeSpan.FromSeconds(2) });
         td.Actions.Add(Constant.ExecutablePath);
 
-        if (IsCurrentUserIsAdmin())
+        // Only if the app is running as administrator, we can set the run level to highest
+        if (_isAdministrator && alwaysRunAsAdministrator)
         {
             td.Principal.RunLevel = TaskRunLevel.Highest;
         }
@@ -212,13 +248,6 @@ private static bool UnscheduleLogonTask()
         }
     }
 
-    private static bool IsCurrentUserIsAdmin()
-    {
-        var identity = WindowsIdentity.GetCurrent();
-        var principal = new WindowsPrincipal(identity);
-        return principal.IsInRole(WindowsBuiltInRole.Administrator);
-    }
-
     private static bool UnscheduleRegistry()
     {
         using var key = Registry.CurrentUser.OpenSubKey(StartupPath, true);

Flow.Launcher/Languages/en.xaml

@@ -46,6 +46,7 @@
     <system:String x:Key="PositionReset">Position Reset</system:String>
     <system:String x:Key="PositionResetToolTip">Reset search window position</system:String>
     <system:String x:Key="queryTextBoxPlaceholder">Type here to search</system:String>
+    <system:String x:Key="admin">(Admin)</system:String>
 
     <!--  Setting General  -->
     <system:String x:Key="flowlauncher_settings">Settings</system:String>
@@ -131,6 +132,10 @@
     <system:String x:Key="historyResultsForHomePage">Show History Results in Home Page</system:String>
     <system:String x:Key="historyResultsCountForHomePage">Maximum History Results Shown in Home Page</system:String>
     <system:String x:Key="homeToggleBoxToolTip">This can only be edited if plugin supports Home feature and Home Page is enabled.</system:String>
+    <system:String x:Key="alwaysRunAsAdministrator">Always run as administrator</system:String>
+    <system:String x:Key="alwaysRunAsAdministratorToolTip">Run Flow Launcher as administrator on system startup</system:String>
+    <system:String x:Key="runAsAdministratorChange">Administrator Mode Change</system:String>
+    <system:String x:Key="runAsAdministratorChangeAndRestart">Do you want to restart as administrator to apply this change? Or you need to run as administrator during next start manually.</system:String>
 
     <!--  Setting Plugin  -->
     <system:String x:Key="searchplugin">Search Plugin</system:String>

Flow.Launcher/MainWindow.xaml.cs

@@ -595,9 +595,13 @@ private void SoundPlay()
 
         private void InitializeNotifyIcon()
         {
+            var text = Win32Helper.IsAdministrator() ?
+                Constant.FlowLauncherFullName + " " + App.API.GetTranslation("admin") :
+                Constant.FlowLauncherFullName;
+
             _notifyIcon = new NotifyIcon
             {
-                Text = Constant.FlowLauncherFullName,
+                Text = text,
                 Icon = Constant.Version == "1.0.0" ? Properties.Resources.dev : Properties.Resources.app,
                 Visible = !_settings.HideNotifyIcon
             };

Flow.Launcher/PublicAPIInstance.cs

@@ -11,7 +11,6 @@
 using System.Threading;
 using System.Threading.Tasks;
 using System.Windows;
-using System.Windows.Input;
 using System.Windows.Media;
 using CommunityToolkit.Mvvm.DependencyInjection;
 using Flow.Launcher.Core;

Flow.Launcher/Resources/Pages/WelcomePage5.xaml.cs

@@ -45,7 +45,7 @@ private void ChangeAutoStartup(bool value)
                 {
                     if (Settings.UseLogonTaskForStartup)
                     {
-                        AutoStartup.ChangeToViaLogonTask();
+                        AutoStartup.ChangeToViaLogonTask(Settings.AlwaysRunAsAdministrator);
                     }
                     else
                     {