-
-
Notifications
You must be signed in to change notification settings - Fork 380
Add get PR authors to workflow #3611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
🥷 Code experts: no user but you matched threshold 10 jjw24 has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
This comment has been minimized.
This comment has been minimized.
📝 WalkthroughWalkthroughThe script responsible for updating release pull requests was modified to refine pull request filtering logic and to introduce a new function for extracting assignee usernames from filtered PRs. The main execution flow now aggregates, deduplicates, and lists PR assignees in the release notes under a new "Authors" section. Changes
Suggested labels
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/update_release_pr.py (1)
110-131
: Refactor list comprehension with side effects for better readability.The function logic is correct and well-documented. However, the list comprehension on line 127 has side effects (appending to
assignee_list
), which reduces readability.Consider using a more explicit loop for better readability:
- [assignee_list.append(assignee["login"]) for assignee in pr["assignees"] if assignee["login"] != "jjw24" ] + for assignee in pr["assignees"]: + if assignee["login"] != "jjw24": + assignee_list.append(assignee["login"])Alternatively, use
extend()
with a generator expression:- [assignee_list.append(assignee["login"]) for assignee in pr["assignees"] if assignee["login"] != "jjw24" ] + assignee_list.extend(assignee["login"] for assignee in pr["assignees"] if assignee["login"] != "jjw24")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/update_release_pr.py
(4 hunks)
🧰 Additional context used
🪛 GitHub Actions: Check Spelling
.github/update_release_pr.py
[warning] 171-171: Spell check warning: vnd
is not a recognized word. (unrecognized-spelling)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: build
🔇 Additional comments (4)
.github/update_release_pr.py (4)
14-14
: Documentation improvement looks good.The clarification that filters are not applied when the label is an empty string improves code readability and understanding.
Also applies to: 92-92
102-102
: Filtering logic correctly implements the intended behavior.The updated logic properly handles both state and label filtering:
- Includes PRs when state matches or is "all"
- Applies label filter only when a non-empty label is provided
106-106
: Print message clarification improves user experience.The updated message clearly indicates when no label filter is applied, making the output more informative.
233-236
: Assignee collection and formatting implementation is well-structured.The code correctly:
- Collects assignees from both enhancement and bug fix PRs
- Deduplicates using
set()
- Sorts case-insensitively
- Formats the output appropriately for the release notes
Uh oh!
There was an error while loading. Please reload this page.