Skip to content

Fixed and Reveals #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
javier-godoy opened this issue Apr 3, 2025 · 1 comment
Open

Fixed and Reveals #135

javier-godoy opened this issue Apr 3, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@javier-godoy
Copy link
Member

Describe the bug

AppLayout have fixed and reveals features, but they are not working in the demo.

/**
* Sets the fixed attribute so it mantains the header fixed at the top
* so it never moves away.
* @param fixed
*/
public void setFixed(boolean fixed) {
getElement().setAttribute("fixed", fixed);
}
/**
* Sets the reveals attribute so it slides back the header when scrolling
* back up.
* @param reveals
*/
public void setReveals(boolean reveals) {
getElement().setAttribute("reveals", reveals);
}

Expected behavior

  • With fixed, the header stays in place at the top at all times.
  • With reveals, the header reappears upon upward scrolling.

Minimal reproducible example

https://addonsv24.flowingcode.com/applayout/applayout-demo

Add-on Version

6.0.1-SNAPSHOT

Vaadin Version

24.7.0

Additional information

No response

@github-project-automation github-project-automation bot moved this to Inbox (needs triage) in Flowing Code Addons Apr 3, 2025
@javier-godoy javier-godoy added the bug Something isn't working label Apr 3, 2025
@mlopezFC
Copy link
Member

mlopezFC commented Apr 3, 2025

Good catch, I was able to reproduce the issue

@paodb paodb moved this from Inbox (needs triage) to To Do in Flowing Code Addons Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To Do
Development

No branches or pull requests

2 participants