-
Notifications
You must be signed in to change notification settings - Fork 3
docs(readme): document allowed-packages #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new section titled "Special configuration when using Spring" has been added to the README file. This section explains that Vaadin Flow, by default, only scans the Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
117-120
: Enhance Clarity and Brevity of the Section Description.
The new "Special configuration when using Spring" section is a useful addition. However, the sentence on line 119 appears a bit wordy. Consider shortening it for clarity, for example:"By default, Vaadin Flow scans only
com/vaadin/flow/component
for UI components. To display the add-on properly, addcom.flowingcode
to your allowed packages."🧰 Tools
🪛 LanguageTool
[style] ~119-~119: Consider a shorter alternative to avoid wordiness.
Context: ...on, the add-on might need to be allowed in order to display correctly. To do so, just add...(IN_ORDER_TO_PREMIUM)
123-125
: Improve Code Block Formatting for Syntax Highlighting.
The configuration snippet would benefit from specifying a language in the fenced code block. For example, changing the block header from “” to “
properties” will enhance readability. Consider applying the following diff:-``` +```properties vaadin.allowed-packages = com.vaadin,org.vaadin,dev.hilla,com.flowingcode -``` +```🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
123-123: Fenced code blocks should have a language specified
null(MD040, fenced-code-language)
123-123: Code block style
Expected: indented; Actual: fenced(MD046, code-block-style)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[style] ~119-~119: Consider a shorter alternative to avoid wordiness.
Context: ...on, the add-on might need to be allowed in order to display correctly. To do so, just add...
(IN_ORDER_TO_PREMIUM)
🪛 markdownlint-cli2 (0.17.2)
README.md
123-123: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
123-123: Code block style
Expected: indented; Actual: fenced
(MD046, code-block-style)
Summary by CodeRabbit