Skip to content

Commit 31efeb0

Browse files
committed
deprecate: deprecate a public attribute
1 parent 7ac1962 commit 31efeb0

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

src/main/java/com/flowingcode/vaadin/addons/gridexporter/DocxStreamResourceWriter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ private void fillData(XWPFTable table, XWPFTableCell dataCell, DataProvider<T, ?
167167
Iterator<Column<T>> iterator = exporter.getColumns().iterator();
168168
while (iterator.hasNext()) {
169169
iterator.next();
170+
// preserve increment for deprecated attribute
170171
exporter.totalcells = exporter.totalcells + 1;
171172
currentRow.createCell();
172173
}

src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,8 @@ public class GridExporter<T> implements Serializable {
124124

125125
SerializableSupplier<String> nullValueSupplier;
126126

127+
/** @deprecated. This attribute is incremented only when exporting DOCX, but it's never reset. */
128+
@Deprecated(since = "2.5.0", forRemoval = true)
127129
public int totalcells = 0;
128130

129131
private ButtonsAlignment buttonsAlignment = ButtonsAlignment.RIGHT;

0 commit comments

Comments
 (0)