Skip to content

Commit 6fe4cb6

Browse files
committed
fix: downgrade commons-demo because of jdk11 support
1 parent 00d57af commit 6fe4cb6

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

pom.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
<dependency>
6262
<groupId>com.flowingcode.vaadin.addons.demo</groupId>
6363
<artifactId>commons-demo</artifactId>
64-
<version>4.1.0</version>
64+
<version>3.6.0</version>
6565
</dependency>
6666
</dependencies>
6767
</dependencyManagement>
@@ -209,8 +209,7 @@
209209
<groupId>javax.servlet</groupId>
210210
<artifactId>javax.servlet-api</artifactId>
211211
<version>3.1.0</version>
212-
<type>jar</type>
213-
<scope>test</scope>
212+
<scope>provided</scope>
214213
</dependency>
215214
<dependency>
216215
<groupId>io.github.bonigarcia</groupId>

src/test/java/com/flowingcode/vaadin/addons/gridexporter/GridExporterBigDatasetDemo.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
package com.flowingcode.vaadin.addons.gridexporter;
2121

2222
import com.flowingcode.vaadin.addons.demo.DemoSource;
23-
import com.flowingcode.vaadin.addons.demo.SourceCodeViewer;
2423
import com.flowingcode.vaadin.addons.gridhelpers.GridHelper;
2524
import com.flowingcode.vaadin.addons.gridhelpers.HeightMode;
2625
import com.github.javafaker.Faker;
@@ -40,7 +39,6 @@
4039
import org.apache.poi.EncryptedDocumentException;
4140

4241
@DemoSource
43-
@DemoSource(clazz = VaadinServiceInitListenerImpl.class)
4442
@PageTitle("Big Dataset")
4543
@Route(value = "gridexporter/bigdataset", layout = GridExporterDemoView.class)
4644
@SuppressWarnings("serial")
@@ -103,9 +101,6 @@ public GridExporterBigDatasetDemo() throws EncryptedDocumentException, IOExcepti
103101

104102

105103
add(block1, grid, block2);
106-
SourceCodeViewer.highlightOnHover(block1, "concurrent");
107-
SourceCodeViewer.highlightOnHover(block2,
108-
"VaadinServiceInitListenerImpl.java#setConcurrentDownloadTimeout");
109104
// #endif
110105
// begin-block concurrent
111106
exporter.setConcurrentDownloadCost(9);

0 commit comments

Comments
 (0)