From 6e049ded1bfb9110f57fcc21209f9e4508c166c2 Mon Sep 17 00:00:00 2001 From: Javier Godoy <11554739+javier-godoy@users.noreply.github.com> Date: Wed, 11 Sep 2024 16:43:27 -0300 Subject: [PATCH 1/4] docs: fix reference to refactored method --- .../addons/gridexporter/ConcurrentDownloadTimeoutEvent.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/flowingcode/vaadin/addons/gridexporter/ConcurrentDownloadTimeoutEvent.java b/src/main/java/com/flowingcode/vaadin/addons/gridexporter/ConcurrentDownloadTimeoutEvent.java index e3c5c1c..6b62d45 100644 --- a/src/main/java/com/flowingcode/vaadin/addons/gridexporter/ConcurrentDownloadTimeoutEvent.java +++ b/src/main/java/com/flowingcode/vaadin/addons/gridexporter/ConcurrentDownloadTimeoutEvent.java @@ -10,8 +10,8 @@ * preventing other listeners from processing the event. *

* - * @param the type of the GridExporter source - * @see GridExporter#setConcurrentDownloadTimeout(long, java.util.concurrent.TimeUnit) + * @see GridExporterConcurrentSettings#setConcurrentDownloadTimeout(long, + * java.util.concurrent.TimeUnit) */ @SuppressWarnings("serial") public class ConcurrentDownloadTimeoutEvent extends EventObject { From 15dc690566d2b1f3140bb21a5071809305d9cefb Mon Sep 17 00:00:00 2001 From: Javier Godoy <11554739+javier-godoy@users.noreply.github.com> Date: Wed, 11 Sep 2024 16:43:41 -0300 Subject: [PATCH 2/4] docs: fix typos in javadoc --- .../vaadin/addons/gridexporter/FooterToolbarItem.java | 6 +++--- .../vaadin/addons/gridexporter/GridExporter.java | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/flowingcode/vaadin/addons/gridexporter/FooterToolbarItem.java b/src/main/java/com/flowingcode/vaadin/addons/gridexporter/FooterToolbarItem.java index 1e059a6..85d50f2 100644 --- a/src/main/java/com/flowingcode/vaadin/addons/gridexporter/FooterToolbarItem.java +++ b/src/main/java/com/flowingcode/vaadin/addons/gridexporter/FooterToolbarItem.java @@ -7,9 +7,9 @@ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. @@ -25,7 +25,7 @@ /** * Item that can be added to {@link FooterToolbar}. *

- * Default position is {@link FooterToolbarItemPosition.AFTER_EXPORT_BUTTONS} + * Default position is {@link FooterToolbarItemPosition#AFTER_EXPORT_BUTTONS} */ public class FooterToolbarItem implements Serializable { diff --git a/src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java b/src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java index 73c09f7..7ec44f7 100644 --- a/src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java +++ b/src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java @@ -761,7 +761,7 @@ public List> getColumns() { } /** - * Get columns in the positions specified by {@link GridExporter.setColumnPosition} + * Get columns in the positions specified by {@link GridExporter#setColumnPosition(Column, int)} */ public List> getColumnsOrdered() { return columns == null From 4630f59601daf4d7b662ebff5904c3a60c3e080b Mon Sep 17 00:00:00 2001 From: Javier Godoy <11554739+javier-godoy@users.noreply.github.com> Date: Wed, 11 Sep 2024 16:49:31 -0300 Subject: [PATCH 3/4] ci: create links to Vaadin javadocs --- pom.xml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index fe00874..80c74bf 100644 --- a/pom.xml +++ b/pom.xml @@ -350,7 +350,7 @@ org.apache.maven.plugins maven-javadoc-plugin - 3.0.1 + 3.10.0 attach-javadocs @@ -363,7 +363,9 @@ true none - -Xdoclint:none + + https://javadoc.io/doc/com.vaadin/vaadin-platform-javadoc/${vaadin.version} + From cef7d0c3ee7143a43ed94bbba8723ed4d59cec74 Mon Sep 17 00:00:00 2001 From: Javier Godoy <11554739+javier-godoy@users.noreply.github.com> Date: Wed, 11 Sep 2024 16:49:43 -0300 Subject: [PATCH 4/4] ci: fail the build if there are warning during javadoc execution --- pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/pom.xml b/pom.xml index 80c74bf..eea2c03 100644 --- a/pom.xml +++ b/pom.xml @@ -363,6 +363,7 @@ true none + true https://javadoc.io/doc/com.vaadin/vaadin-platform-javadoc/${vaadin.version}