Update CI for release through Maven central #122
Conversation
WalkthroughThe pull request involves modifications to the project's build configuration and metadata. The changes include removing two assembly-related files ( Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
pom.xml (2)
45-50: Consider adding snapshotRepository configuration.While the staging repository configuration is correct, consider adding a snapshotRepository for development versions:
<distributionManagement> <repository> <id>ossrh</id> <url>https://s01.oss.sonatype.org/service/local/staging/deploy/maven2/</url> </repository> + <snapshotRepository> + <id>ossrh</id> + <url>https://s01.oss.sonatype.org/content/repositories/snapshots/</url> + </snapshotRepository> </distributionManagement>
Line range hint
1-516: Maven Central release configuration is complete.All required elements for Maven Central deployment are properly configured:
- Project metadata (URL, SCM, license, developers)
- Distribution management with OSSRH repository
- Source and Javadoc generation
- GPG signing
Consider setting up GitHub Actions workflow for automated releases to Maven Central using these configurations.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
assembly/MANIFEST.MF(0 hunks)assembly/assembly.xml(0 hunks)pom.xml(3 hunks)
💤 Files with no reviewable changes (2)
- assembly/MANIFEST.MF
- assembly/assembly.xml
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-vaadin24
🔇 Additional comments (3)
pom.xml (3)
10-10: LGTM! Required metadata for Maven Central.The project URL is a required field for Maven Central deployment.
300-300: LGTM! Optimized build lifecycle.Moving source JAR generation to 'package' phase is a valid optimization as it doesn't depend on verification.
Line range hint
308-332: Verify Vaadin Javadoc URL compatibility.The Javadoc configuration looks good with proper settings for Maven Central requirements. However, let's verify the Vaadin Javadoc URL pattern:
✅ Verification successful
Javadoc URL configuration is correct and flexible ✅
The Javadoc URL will automatically adapt to the active profile's Vaadin version (23.3.15, 23.3.5, or 24.2.6), ensuring correct documentation links regardless of the build profile used.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if the Vaadin Javadoc URL pattern is valid for the configured version # Extract Vaadin version VAADIN_VERSION=$(grep -A1 '<vaadin.version>' pom.xml | grep -v '<vaadin.version>' | tr -d ' \t</>') # Check if Javadoc URL exists echo "Checking Javadoc URL for Vaadin version: $VAADIN_VERSION" curl -s -I "https://javadoc.io/doc/com.vaadin/vaadin-platform-javadoc/$VAADIN_VERSION" | head -n 1Length of output: 801
Script:
#!/bin/bash # First, check if vaadin.version property exists and extract it echo "Checking for vaadin.version property:" grep -A1 '<vaadin.version>' pom.xml # Use a more precise extraction with awk echo -e "\nExtracting Vaadin version:" awk '/<vaadin.version>/{getline; print}' pom.xml | sed 's/[[:space:]]//g' | sed 's/<.*>//g'Length of output: 574
Script:
#!/bin/bash # Get context around Javadoc plugin to identify its profile echo "Profile context for Javadoc plugin:" grep -B10 -A2 "maven-javadoc-plugin" pom.xml # Get full profile context for Vaadin versions echo -e "\nProfile context for Vaadin versions:" grep -B5 -A1 "<vaadin.version>" pom.xmlLength of output: 1360
Change in CI for release through Maven central (#121)
Summary by CodeRabbit
Release Notes
Chores
Documentation
Build Process