Skip to content

Commit 51b11c1

Browse files
committed
fix: fix aspect type
1 parent 44d3936 commit 51b11c1

File tree

2 files changed

+38
-38
lines changed

2 files changed

+38
-38
lines changed

src/main/java/com/flowingcode/vaadin/addons/imagecrop/ImageCrop.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ public Crop getCrop() {
153153
*
154154
* @param aspect the aspect ratio of the crop
155155
*/
156-
public void setAspect(Double aspect) {
156+
public void setAspect(double aspect) {
157157
setState("aspect", aspect);
158158
}
159159

@@ -162,7 +162,7 @@ public void setAspect(Double aspect) {
162162
*
163163
* @return the aspect ratio
164164
*/
165-
public Double getAspect() {
165+
public double getAspect() {
166166
return getState("aspect", Double.class);
167167
}
168168

src/test/java/com/flowingcode/vaadin/addons/imagecrop/test/ImageCropTest.java

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -17,51 +17,51 @@
1717

1818
public class ImageCropTest {
1919

20-
private ImageCrop imageCrop;
20+
private ImageCrop imageCrop;
2121

22-
@Before
23-
public void setUp() {
24-
imageCrop = new ImageCrop("dummyImageSrc");
25-
}
22+
@Before
23+
public void setUp() {
24+
imageCrop = new ImageCrop("dummyImageSrc");
25+
}
2626

27-
@Test
28-
public void testSetAndGetImageSrc() {
29-
String expectedSrc = "newImageSrc";
30-
imageCrop.setImageSrc(expectedSrc);
31-
assertEquals(expectedSrc, imageCrop.getImageSrc());
32-
}
27+
@Test
28+
public void testSetAndGetImageSrc() {
29+
String expectedSrc = "newImageSrc";
30+
imageCrop.setImageSrc(expectedSrc);
31+
assertEquals(expectedSrc, imageCrop.getImageSrc());
32+
}
3333

34-
@Test
35-
public void testSetAndGetCrop() {
36-
Crop expectedCrop = new Crop("%", 10, 10, 200, 200);
37-
imageCrop.setCrop(expectedCrop);
38-
assertEquals(expectedCrop, imageCrop.getCrop());
39-
}
34+
@Test
35+
public void testSetAndGetCrop() {
36+
Crop expectedCrop = new Crop("%", 10, 10, 200, 200);
37+
imageCrop.setCrop(expectedCrop);
38+
assertEquals(expectedCrop, imageCrop.getCrop());
39+
}
4040

41-
@Test
42-
public void testSetAndGetAspect() {
43-
Double expectedAspect = 16.0 / 9.0;
44-
imageCrop.setAspect(expectedAspect);
45-
assertEquals(expectedAspect, imageCrop.getAspect());
46-
}
41+
@Test
42+
public void testSetAndGetAspect() {
43+
Double expectedAspect = 16.0 / 9.0;
44+
imageCrop.setAspect(expectedAspect);
45+
assertEquals(expectedAspect, Double.valueOf(imageCrop.getAspect()));
46+
}
4747

48-
@Test
49-
public void testEncodedCroppedImageEvent() {
48+
@Test
49+
public void testEncodedCroppedImageEvent() {
5050
String expectedCroppedImageUri = "croppedImageUri";
5151
CroppedImageEvent event = mock(CroppedImageEvent.class);
5252
when(event.getCroppedImageDataUri()).thenReturn(expectedCroppedImageUri);
5353
imageCrop = mock(ImageCrop.class);
5454
when(imageCrop.getCroppedImageDataUri()).thenReturn(expectedCroppedImageUri);
5555
assertEquals(expectedCroppedImageUri, imageCrop.getCroppedImageDataUri());
56-
}
56+
}
5757

58-
@Test
59-
public void testGetCroppedImageBase64() {
60-
byte[] expectedCroppedImageBytes = Base64.getDecoder().decode("SGVsbG8gV29ybGQ=");
61-
imageCrop = mock(ImageCrop.class);
62-
when(imageCrop.getCroppedImageBase64()).thenReturn(expectedCroppedImageBytes);
63-
byte[] actualCroppedImageBytes = imageCrop.getCroppedImageBase64();
64-
assertNotNull(actualCroppedImageBytes);
65-
assertArrayEquals(expectedCroppedImageBytes, actualCroppedImageBytes);
66-
}
67-
}
58+
@Test
59+
public void testGetCroppedImageBase64() {
60+
byte[] expectedCroppedImageBytes = Base64.getDecoder().decode("SGVsbG8gV29ybGQ=");
61+
imageCrop = mock(ImageCrop.class);
62+
when(imageCrop.getCroppedImageBase64()).thenReturn(expectedCroppedImageBytes);
63+
byte[] actualCroppedImageBytes = imageCrop.getCroppedImageBase64();
64+
assertNotNull(actualCroppedImageBytes);
65+
assertArrayEquals(expectedCroppedImageBytes, actualCroppedImageBytes);
66+
}
67+
}

0 commit comments

Comments
 (0)