Skip to content

Automatic dark mode support based on theme variant #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mlopezFC opened this issue Nov 12, 2024 · 1 comment · May be fixed by #15
Open

Automatic dark mode support based on theme variant #10

mlopezFC opened this issue Nov 12, 2024 · 1 comment · May be fixed by #15
Assignees
@flang @mlopezFC
Labels
enhancement New feature or request

Comments

@mlopezFC
Copy link
Member

Feature proposal

If the dark mode theme variant is applied to the current page, it should affect also the color mode support of the component.

Describe solution expectations

If the dark mode is set on the Vaadin view by using the annotation or programmatic approach, the component should automatically change to dark mode.

Additional information

No response
@mlopezFC mlopezFC added the enhancement New feature or request label Nov 12, 2024
@mlopezFC mlopezFC self-assigned this Nov 12, 2024
@github-project-automation github-project-automation bot moved this to Inbox (needs triage) in Flowing Code Addons Nov 12, 2024
flang added a commit that referenced this issue Apr 14, 2025
@flang
feat: apply application's theme to MarkdownEditor component
155178b 
Close #10
@flang flang self-assigned this Apr 14, 2025
@flang flang moved this from To Do to In Progress in Flowing Code Addons Apr 14, 2025
@flang flang linked a pull request Apr 14, 2025 that will close this issue
Open
@mlopezFC
Copy link
Member Author

We discussed this and made the decision to eliminate the dataColorMode getter/setter and completely rely on Vaadin theme handling mechanism.

flang added a commit that referenced this issue Apr 25, 2025
@flang
feat: remove setDataColorMode from API to rely on Vaadin theme
c863f14 
Close #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flang flang

@mlopezFC mlopezFC

Labels
enhancement New feature or request
Projects
Flowing Code Addons
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply application's theme to MarkdownEditor component FlowingCode/MarkdownEditor
2 participants
@flang @mlopezFC