Skip to content

Problem with xml highlighting #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djarnis73 opened this issue May 9, 2025 · 5 comments
Open

Problem with xml highlighting #7

djarnis73 opened this issue May 9, 2025 · 5 comments
Assignees

Comments

@djarnis73
Copy link

djarnis73 commented May 9, 2025

Describe the bug

When trying out the highlighter on an xml document with "special" letters in element names the highlight looks wrong.

If you try the demo application on the following input (using XML language):

<?xml version="1.0" encoding="UTF-8"?>
<root>
    <element>value1</element>
    <élement>value2</élement>
</root>

You get the following result
Image
Note the unformatted second element.

I tried if I could reproduce it using https://highlightjs.org/demo it works there.

I really have no clue what could cause this.

Expected behavior

No response

Minimal reproducible example

No response

Add-on Version

1.0.0

Vaadin Version

24.7.5

Additional information

No response

@github-project-automation github-project-automation bot moved this to Inbox (needs triage) in Flowing Code Addons May 9, 2025
@djarnis73
Copy link
Author

Wonder if it can be related to this commit highlightjs/highlight.js@7addd66 which looks like is in v11.6.0

@javier-godoy
Copy link
Member

Wonder if it can be related to this commit highlightjs/highlight.js@7addd66 which looks like is in v11.6.0

Hello. That's likely. react-syntax-highlighter depends on highlight.js 10.x, while the fix for highlightjs/highlight.js#3529 is, as you mentioned, in 11.6.0.

@djarnis73
Copy link
Author

djarnis73 commented May 12, 2025

Yeah, so I guess that it could take a long time getting this fixed.

@mlopezFC
Copy link
Member

Maybe we could test if it is possible to force using 11.6.0 in our wrapper and see what happens.

@mlopezFC mlopezFC self-assigned this May 13, 2025
@mlopezFC mlopezFC moved this from Inbox (needs triage) to To Do in Flowing Code Addons May 13, 2025
@djarnis73
Copy link
Author

That would be lovely, I have no clue if that major bump is a real incompatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Do
Development

No branches or pull requests

3 participants