-
Notifications
You must be signed in to change notification settings - Fork 8
fix: align buttons in horizontal orientation #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request introduces a styling enhancement in the TwinColGrid component. In the Java class, a new CSS class is applied to the Changes
Suggested reviewers
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/resources/META-INF/resources/frontend/styles/twincol-grid.css (1)
47-50
: CSS Rule for.fake-button-container-label
AddedThis new rule correctly sets the font size and applies a negative bottom margin to elements with the
.fake-button-container-label
class within the twincol-grid context. This aligns with the PR objective to adjust button alignment horizontally. For improved readability and to ensure cross-browser compatibility, consider adding spaces in the calc expression (e.g., use"calc(var(--vaadin-button-margin, var(--lumo-space-xs)) * -1)"
).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/main/java/com/flowingcode/vaadin/addons/twincolgrid/TwinColGrid.java
(1 hunks)src/main/resources/META-INF/resources/frontend/styles/twincol-grid.css
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-vaadin24
🔇 Additional comments (1)
src/main/java/com/flowingcode/vaadin/addons/twincolgrid/TwinColGrid.java (1)
377-379
: Assign New CSS Class to Fake Button Container LabelThe addition of
fakeButtonContainerLabel.setClassName("fake-button-container-label")
ensures that the new CSS styling is applied to the fake button container label. This change is consistent with the styling enhancements outlined in the PR and will help achieve the desired horizontal button alignment. Please verify that the class name matches exactly with the one defined in the CSS file.
Close #174
Summary by CodeRabbit