fix: prevent infinite recursion when updating year

[javier-godoy]

Close #94

year already has notify: true. Not sure what the intention was in #44.

Summary by CodeRabbit

• Refactor
  • The calendar component’s behavior has been streamlined for a more consistent experience. It no longer automatically updates its displayed year when changes occur, resulting in a more stable view. Users might now need to refresh or verify the year display manually as the dynamic update capability has been simplified.

[coderabbitai]

Walkthrough

This change removes the handling for the "year-changed" event from the FcYearCalendarElement component. The event listener registrations in both the connectedCallback and disconnectedCallback methods have been removed, along with the _onYearChanged method that previously processed the event. These modifications ensure that the component no longer responds to year change events, addressing issues related to recursive event triggering when the year property is set programmatically.

Changes

File Path	Change Summary
src/.../fc-year-calendar.js	Removed event listener registrations in connectedCallback/disconnectedCallback and deleted the _onYearChanged method handling the "year-changed" event.

Assessment against linked issues

Objective	Addressed	Explanation
Prevent infinite recursion on year update (#94)	✅

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between afea23c and 239405f.

📒 Files selected for processing (1)

• src/main/resources/META-INF/frontend/fc-year-calendar/fc-year-calendar.js (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build-vaadin24

🔇 Additional comments (1)

src/main/resources/META-INF/frontend/fc-year-calendar/fc-year-calendar.js (1)

324-324: Good fix for the infinite recursion issue!

The removal of the _onYearChanged method is the right approach to fix the infinite recursion problem. Based on the PR description, this method was likely causing an infinite loop because:

1. The year property has notify: true (line 85), which means it automatically dispatches a "year-changed" event when updated
2. The removed handler was listening for the "year-changed" event and then updating the year property again, creating an infinite loop

This change maintains the notification functionality of the year property while eliminating the recursive event handling that was causing the issue described in #94.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud