fix: remove unused description prop in list-item (#208)

ForkbombEu · Feb 14, 2025 · 7b191ca · 7b191ca
1 parent 101bc29
commit 7b191ca
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 14 deletions.
diff --git a/src/components.d.ts b/src/components.d.ts
@@ -12,7 +12,6 @@ export { Tab } from "./components/tab-button/d-tab-button";
 export namespace Components {
     interface DActivityCard {
         "date": string;
-        "description": string;
         "href"?: string;
         "logo": string;
         "message": string;
@@ -137,7 +136,6 @@ export namespace Components {
     }
     interface DListItem {
         "background"?: boolean;
-        "description"?: string;
         "href"?: string;
         "issuer"?: string;
         "logoSrc"?: string;
@@ -626,7 +624,6 @@ declare global {
 declare namespace LocalJSX {
     interface DActivityCard {
         "date"?: string;
-        "description"?: string;
         "href"?: string;
         "logo"?: string;
         "message"?: string;
@@ -759,7 +756,6 @@ declare namespace LocalJSX {
     }
     interface DListItem {
         "background"?: boolean;
-        "description"?: string;
         "href"?: string;
         "issuer"?: string;
         "logoSrc"?: string;

diff --git a/src/components/activity-card/activity.stories.ts b/src/components/activity-card/activity.stories.ts
@@ -7,7 +7,6 @@ const meta = {
     `<d-vertical-stack separator> <d-activity-card
       message="${args.message}" 
       logo="${args.logo}" 
-      description="${args.description}" 
       date="${args.date}" 
     ${args.message && `message="${args.message}"`}
     ${args.read && `read="${args.read}"`}
@@ -22,7 +21,6 @@ const meta = {
     <d-activity-card
       message="${args.message}"
       logo="${args.logo}" 
-      description="${args.description}" 
       date="${args.date}" 
     ${args.message && `message="${args.message}"`}
     ${args.read && `read="${args.read}"`}
@@ -44,7 +42,6 @@ export const Default: Story = {
   args: {
     logo: `https://api.dicebear.com/7.x/open-peeps/svg?seed=${new Date()}`,
     message: 'Proof of humanity is expired',
-    description: 'Your proof of humanity has expired. Please renew it if you need it.',
     date: '1 day ago',
   },
 };

diff --git a/src/components/activity-card/d-activity-card.tsx b/src/components/activity-card/d-activity-card.tsx
@@ -8,15 +8,14 @@ import { Component, Host, Prop, h } from '@stencil/core';
 export class DActivityCard {
   @Prop({ reflect: true }) message: string;
   @Prop({ reflect: true }) logo: string;
-  @Prop({ reflect: true }) description: string;
   @Prop({ reflect: true }) date: string;
   @Prop({ reflect: true }) read: boolean = false;
   @Prop({ reflect: true }) href?: string;
 
   render() {
     return (
       <Host>
-        <d-list-item name={this.message} logo-src={this.logo} href={this.href} description={this.description}>
+        <d-list-item name={this.message} logo-src={this.logo} href={this.href}>
           <div slot="date">
             <div class="flex items-center gap-2.5">
               {!this.read && <d-info-led type="warning" />}

diff --git a/src/components/credential-service/credential-services.stories.ts b/src/components/credential-service/credential-services.stories.ts
@@ -6,7 +6,6 @@ const meta = {
   render: args => `<d-credential-service 
   name="${args.name}" 
   issuer="${args.issuer}" 
-  description="${args.description}" 
   href="${args.href}" 
   logo-src="${args.logoSrc}"
   ></d-credential-service>`,
@@ -18,7 +17,6 @@ type Story = StoryObj<Components.DCredentialService>;
 export const Default: Story = {
   args: {
     name: 'Over 18',
-    description: 'Age Validation',
     issuer: 'Italian Government',
     logoSrc: `https://api.dicebear.com/9.x/icons/svg?seed=${new Date()}`,
   },

diff --git a/src/components/credential-service/d-credential-service.tsx b/src/components/credential-service/d-credential-service.tsx
@@ -10,7 +10,6 @@ export class DCredentialService {
   @Prop() issuer: string;
   @Prop({ attribute: 'logo-src' }) logoSrc?: string;
   @Prop() organization?: string;
-  @Prop() description?: string;
   @Prop({ reflect: true }) href?: string;
 
 
@@ -21,7 +20,6 @@ export class DCredentialService {
           name={this.name}
           issuer={this.issuer}
           logo-src={this.logoSrc}
-          description={this.description}
           href={this.href}
           background
         >

diff --git a/src/components/d-list-item/d-list-item.tsx b/src/components/d-list-item/d-list-item.tsx
@@ -9,7 +9,6 @@ export class DListItem {
   @Prop() name: string;
   @Prop() issuer?: string;
   @Prop({ attribute: 'logo-src' }) logoSrc?: string;
-  @Prop() description?: string;
   @Prop({ reflect: true }) href?: string;
   @Prop() background?: boolean;