Merge branch 'main' into ts-migrate/victory-native

Author: KenanYusuf

.changeset/silver-feet-doubt.md .changeset/brave-cycles-matter.md

@@ -1,20 +1,34 @@
 ---
+"victory-area": patch
 "victory-axis": patch
 "victory-bar": patch
 "victory-box-plot": patch
 "victory-brush-container": patch
 "victory-brush-line": patch
 "victory-candlestick": patch
+"victory-canvas": patch
 "victory-chart": patch
 "victory-core": patch
-"victory-create-container": patch
+"victory-cursor-container": patch
 "victory-errorbar": patch
+"victory-group": patch
+"victory-histogram": patch
 "victory-legend": patch
+"victory-line": patch
+"victory-native": patch
+"victory-pie": patch
 "victory-polar-axis": patch
+"victory-scatter": patch
 "victory-selection-container": patch
 "victory-shared-events": patch
 "victory-stack": patch
+"victory-tooltip": patch
+"victory-voronoi": patch
 "victory-voronoi-container": patch
+"victory": patch
+"victory-create-container": patch
+"victory-vendor": patch
+"victory-zoom-container": patch
 ---
 
-Refactor param reassignments
+Replace instances of lodash.assign with Object.assign

.changeset/eight-bananas-itch.md

@@ -17,6 +17,7 @@ module.exports = {
     "plugin:react-hooks/recommended",
     "plugin:eslint-comments/recommended",
     "prettier",
+    "plugin:storybook/recommended",
   ],
   rules: {
     "eslint-comments/disable-enable-pair": "off",

.changeset/kind-rivers-kick.md

@@ -1,8 +1,12 @@
 name: Chromatic
 
 # Runs chromatic on:
-#   every pull request where there are changes in stories/ or packages/ and the PR is not in draft mode
+# - every push to main (to create a chromatic baseline)
+# - every pull request where there are changes in stories/ or packages/ and the PR is not in draft mode
 on:
+  push:
+    branches:
+      - main
   pull_request:
     branches:
       - main
@@ -21,13 +25,12 @@ jobs:
         with:
           fetch-depth: 0
 
-      # requires node16, see https://github.com/FormidableLabs/victory/issues/2668
       - uses: ./.github/actions/setup
         with:
-          node-version: 16.x
+          node-version: 18.x
 
-      - name: Build Storybook
-        run: pnpm run storybook:build
+      - name: Build Victory
+        run: pnpm run build:lib:esm
 
       - name: Publish to Chromatic
         uses: chromaui/action@v1

.changeset/long-files-itch.md

@@ -0,0 +1,69 @@
+import type { StorybookConfig } from "@storybook/react-webpack5";
+
+/* globals __dirname:false */
+const path = require("path");
+const glob = require("glob");
+const ROOT = path.resolve(__dirname, "..");
+const PKGS = path.resolve(ROOT, "packages");
+const STORIES = path.resolve(ROOT, "stories");
+
+const wrapForPnp = (packageName) =>
+  path.dirname(require.resolve(path.join(packageName, "package.json")));
+
+const config: StorybookConfig = {
+  webpackFinal: async (config) => {
+    // Read all the victory packages and alias.
+    glob.sync(path.join(PKGS, "victory*/package.json")).forEach((pkgPath) => {
+      const key = path.dirname(path.relative(PKGS, pkgPath));
+      if (config?.resolve?.alias) {
+        config.resolve.alias[key] = path.resolve(path.dirname(pkgPath));
+      }
+    });
+
+    return config;
+  },
+
+  addons: [
+    "@storybook/addon-essentials",
+    {
+      name: "@storybook/addon-storysource",
+      options: {
+        rule: {
+          test: [/\.stories\.(jsx?|tsx?)$/],
+          include: [STORIES],
+        },
+        loaderOptions: {
+          prettierConfig: { printWidth: 80, singleQuote: false },
+        },
+      },
+    },
+  ],
+
+  // Use glob to locate the stories, because it ignores our circular dependencies.
+  stories: glob.sync("../**/*.stories.@(js|jsx|ts|tsx)", {
+    cwd: __dirname,
+  }),
+
+  framework: {
+    name: wrapForPnp("@storybook/react-webpack5"),
+    options: {
+      builder: {
+        useSWC: true,
+      },
+    },
+  },
+
+  typescript: {
+    // typescript compilation check is disabled until we upgrade the babel version
+    // which is required for the latest version of storybook to do typechecking
+    // https://github.com/FormidableLabs/victory/issues/2746
+    check: false,
+    checkOptions: {
+      typescript: {
+        configFile: path.join(__dirname, "../tsconfig.base.json"),
+      },
+    },
+  },
+};
+
+export default config;

.changeset/olive-bananas-stare.md

@@ -6,7 +6,6 @@ import { VictoryArea } from "victory-area";
 import { VictoryBar } from "victory-bar";
 import { VictoryLine } from "victory-line";
 import { VictoryTheme, VictoryLabel } from "victory-core";
-import { merge } from "lodash";
 
 class App extends React.Component {
   render() {
@@ -104,7 +103,7 @@ class App extends React.Component {
                         target: "data",
                         mutation: (props) => {
                           return {
-                            style: merge({}, props.style, { stroke: "lime" }),
+                            style: Object.assign({}, props.style, { stroke: "lime" }),
                           };
                         },
                       },
@@ -113,7 +112,7 @@ class App extends React.Component {
                         target: "labels",
                         mutation: (props) => {
                           return {
-                            style: merge({}, props.style, { fill: "green" }),
+                            style: Object.assign({}, props.style, { fill: "green" }),
                             text: "waddup",
                           };
                         },

.changeset/silver-weeks-attend.md

@@ -8,7 +8,7 @@ import { VictoryBar } from "victory-bar";
 import { VictoryLine } from "victory-line";
 import { VictoryZoomContainer } from "victory-zoom-container";
 import { VictoryVoronoiContainer } from "victory-voronoi-container";
-import { range, assign } from "lodash";
+import { range } from "lodash";
 
 class App extends React.Component {
   constructor() {
@@ -52,8 +52,8 @@ class App extends React.Component {
           mutation: (props) => {
             const fill = props.style && props.style.fill;
             return fill === "blue"
-              ? { style: assign({}, props.style, { fill: "red" }) }
-              : { style: assign({}, props.style, { fill: "blue" }) };
+              ? { style: Object.assign({}, props.style, { fill: "red" }) }
+              : { style: Object.assign({}, props.style, { fill: "blue" }) };
           },
           callback,
         },