Merge pull request #1732 from keithbro/bugfix/histogram-bins

Omit first and last bins when specifying d3-array thresholds.

Author: boygirl

packages/victory-histogram/src/helper-methods.js

@@ -43,7 +43,7 @@ const getBinningFunc = ({ data, x, bins, dataOrBinsContainsDates }) => {
 
   if (Array.isArray(bins)) {
     bin.domain([bins[0], bins[bins.length - 1]]);
-    bin.thresholds(bins);
+    bin.thresholds(bins.slice(1, bins.length - 1));
 
     return bin;
   }

test/client/spec/victory-histogram/victory-histogram.spec.js

@@ -61,6 +61,17 @@ describe("components/victory-histogram", () => {
       expect(bars.length).to.be.greaterThan(0);
     });
 
+    it("renders 2 bars of equal height", () => {
+      const data = [{ x: 2 }, { x: 3 }];
+      const wrapper = mount(<VictoryHistogram data={data} bins={[2, 2.5, 3]} />);
+      const bars = wrapper.find("Bar");
+      const heights = bars.map(SvgTestHelper.getBarHeight).map((n) => parseInt(n));
+
+      expect(bars.length).to.equal(2);
+      expect(heights[0]).to.equal(heights[1]);
+      expect(heights[0]).to.be.greaterThan(0);
+    });
+
     it("renders bars values with null accessor", () => {
       const data = range(30);
       const wrapper = shallow(<VictoryHistogram data={data} x={null} y={null} />);