Remove disused cx and cy props from Background, ensure that background prop getter is only invoked when it's going to be used

Author: maddles

demo/js/components/victory-chart-demo.js

@@ -182,8 +182,7 @@ class App extends React.Component {
     };
     const chartStyle = {
       parent: { border: "1px solid #ccc", margin: "2%", maxWidth: "40%" }
-    }
-    ;
+    };
     const axisStyle = {
       grid: { stroke: "grey", strokeWidth: 1 },
       axis: { stroke: "transparent" },
@@ -193,7 +192,7 @@ class App extends React.Component {
 
     const bgStyle = {
       background: { fill: "#e6e6ff" }
-    }
+    };
 
     return (
       <div className="demo">

packages/victory-chart/src/helper-methods.js

@@ -57,6 +57,7 @@ function getBackgroundWithProps(props, calculatedProps) {
   const backgroundProps = {
     height,
     polar: props.polar,
+    scale: calculatedProps.scale,
     style: props.style.background,
     x: xCoordinate,
     y: yCoordinate,

packages/victory-chart/src/victory-chart.js

@@ -92,14 +92,15 @@ export default class VictoryChart extends React.Component {
   getNewChildren(props, childComponents, calculatedProps) {
     const children = getChildren(props, childComponents, calculatedProps);
     const getAnimationProps = Wrapper.getAnimationProps.bind(this);
-    const backgroundComponent = getBackgroundWithProps(props, calculatedProps);
 
     const newChildren = children.map((child, index) => {
       const childProps = assign({ animate: getAnimationProps(props, child, index) }, child.props);
       return React.cloneElement(child, childProps);
     });
 
     if (props.style && props.style.background) {
+      const backgroundComponent = getBackgroundWithProps(props, calculatedProps);
+
       newChildren.unshift(backgroundComponent);
     }
 

packages/victory-core/src/index.d.ts

@@ -662,8 +662,6 @@ export class VictoryPortal extends React.Component<VictoryPortalProps, any> {}
 
 export interface BackgroundProps extends VictoryCommonPrimitiveProps {
   circleComponent?: React.ReactElement;
-  cx?: number;
-  cy?: number;
   height?: number;
   rectComponent?: React.ReactElement;
   width?: number;

packages/victory-core/src/victory-primitives/background.js

@@ -30,8 +30,6 @@ const Background = (props) => {
 Background.propTypes = {
   ...CommonProps.primitiveProps,
   circleComponent: PropTypes.element,
-  cx: PropTypes.number,
-  cy: PropTypes.number,
   height: PropTypes.number,
   rectComponent: PropTypes.element,
   width: PropTypes.number,