Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove static properties on Victory components #2357

Closed
becca-bailey opened this issue Jul 8, 2022 · 0 comments
Closed

Remove static properties on Victory components #2357

becca-bailey opened this issue Jul 8, 2022 · 0 comments
Labels
Status: On Hold ⚠️ This issue has prerequisites before it can be addressed
Milestone

Comments

@becca-bailey
Copy link
Contributor

Victory relies on static properties in order to get calculated props, and make decisions about which props to pass into which Victory components. The static role property in particular is the source of a lot of confusion, as documented in issues like #2342 and #2128.

Rather than relying on top-down architecture where the Victory container component calculates all props and makes inferences about its children, we're working on developing a two-way binding between Victory child components and the parent components where Victory children can sync their props with the parent component, and the parent component will store the calculated chart values in context. This will eliminate the need for these static properties.

This most likely is not going to be a separate piece of work from the existing component re-write tickets, but I'm creating this ticket as a placeholder to encapsulate any bug reports that come in around this issue in the mean time.

@becca-bailey becca-bailey added the Status: On Hold ⚠️ This issue has prerequisites before it can be addressed label Jul 8, 2022
@becca-bailey becca-bailey added this to the Victory Turbo milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: On Hold ⚠️ This issue has prerequisites before it can be addressed
Projects
None yet
Development

No branches or pull requests

2 participants