You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Victory relies on static properties in order to get calculated props, and make decisions about which props to pass into which Victory components. The static role property in particular is the source of a lot of confusion, as documented in issues like #2342 and #2128.
Rather than relying on top-down architecture where the Victory container component calculates all props and makes inferences about its children, we're working on developing a two-way binding between Victory child components and the parent components where Victory children can sync their props with the parent component, and the parent component will store the calculated chart values in context. This will eliminate the need for these static properties.
This most likely is not going to be a separate piece of work from the existing component re-write tickets, but I'm creating this ticket as a placeholder to encapsulate any bug reports that come in around this issue in the mean time.
The text was updated successfully, but these errors were encountered:
Victory relies on static properties in order to get calculated props, and make decisions about which props to pass into which Victory components. The static
role
property in particular is the source of a lot of confusion, as documented in issues like #2342 and #2128.Rather than relying on top-down architecture where the Victory container component calculates all props and makes inferences about its children, we're working on developing a two-way binding between Victory child components and the parent components where Victory children can sync their props with the parent component, and the parent component will store the calculated chart values in context. This will eliminate the need for these static properties.
This most likely is not going to be a separate piece of work from the existing component re-write tickets, but I'm creating this ticket as a placeholder to encapsulate any bug reports that come in around this issue in the mean time.
The text was updated successfully, but these errors were encountered: