Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Victory Portal useId Hook Breaking Change for React v17 Apps #2914

Closed
2 tasks done
lsbyerley opened this issue Oct 14, 2024 · 2 comments
Closed
2 tasks done

Victory Portal useId Hook Breaking Change for React v17 Apps #2914

lsbyerley opened this issue Oct 14, 2024 · 2 comments
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: Bug 🐛 Oh no! A bug or unintentional behavior

Comments

@lsbyerley
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct

Victory version

37.1.0

Code Sandbox link

No response

Bug report

Starting in version 37.1.0, the `victory-portal.tsx` component starts using the `useId` hook. This hook is only available in React v18. We have had to downgrade our victory version to `37.0.2` to avoid this breaking change in our React v17 application. 

Link to the release: https://github.com/FormidableLabs/victory/releases/tag/v37.1.0

Steps to reproduce

Use any victory version starting with 37.1.0 in a react v17 application and observe the runtime error.

Expected behavior

Upgrading victory versions should not break react v17 applications

Actual behavior

No response

Environment

No response

@lsbyerley lsbyerley added the Type: Bug 🐛 Oh no! A bug or unintentional behavior label Oct 14, 2024
@carbonrobot carbonrobot added the Issue: Accepted The submitted issue has been confirmed by the Victory core team label Oct 14, 2024
@carbonrobot
Copy link
Contributor

Thanks for letting us know, we will correct this as soon as possible

@nlkluth nlkluth mentioned this issue Oct 14, 2024
12 tasks
@carbonrobot
Copy link
Contributor

Released in 37.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: Bug 🐛 Oh no! A bug or unintentional behavior
Projects
None yet
Development

No branches or pull requests

2 participants